Conversation
|
Hi @harsha3330. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: saiharsha <[email protected]>
api/v1alpha1/etcdcluster_types.go
Outdated
| type PodTemplate struct { | ||
| // Metadata is the metadata to add to the pod. | ||
| Metadata *PodMetadata `json:"metadata,omitempty"` | ||
| PodSpec *PodSpec `json:"spec,omitempty"` |
There was a problem hiding this comment.
Suggestion to use Spec for consistency with Metadata.
| PodSpec *PodSpec `json:"spec,omitempty"` | |
| Spec *PodSpec `json:"spec,omitempty"` |
|
/ok-to-test |
Signed-off-by: saiharsha <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harsha3330 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: saiharsha <[email protected]>
|
@harsha3330: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@ivanvc can you review the changes |
Added Affinity , Tolerations and Nodeselector for stateful set pod scheduling
Issue : #293