Select install directory to build by fmrico · Pull Request #18 · esteve/ros2_pepper

fmrico · 2018-04-14T09:57:56Z

By setting the environment variable BASE_ROOT, you are able to select where to create the System directory where to install, instead of a fixed .ros_root in the root project directory.

If you do not set BASE_ROOT, the System directory where to install will be in the root project directory.

fmrico · 2018-04-14T09:59:47Z

appveyor check failed? :S

Everitying is building for me...

esteve · 2018-04-19T10:27:08Z

@fmrico Thanks for the PR! Don't worry about Appveyor, I added it as a test, but I don't think I'll keep using it for the time being.

esteve · 2018-04-19T08:14:56Z

README.md

+If you want to set the install directory (instead of the project root directory), set the `BASE_ROOT` environment variable:
+
+```
+export export BASE_ROOT=/home/mihome/pepper_root/  <-- Or wherever you want


s#export export#export#

s#/home/mihome#$HOME#

Also, it'd be better to prefix this variable with PEPPER_ or PEPPER_ROS_ to avoid any conflicts, BASE_ROOT is too generic

esteve · 2018-04-19T08:15:40Z

build_ros1.sh

 PYTHON2_VERSION=${PYTHON2_MAJOR_VERSION}.${PYTHON2_MINOR_VERSION}.${PYTHON2_PATCH_VERSION}

-INSTALL_ROOT=.ros-root
+HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System


HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/System"

esteve · 2018-04-19T08:16:27Z

install.sh

-if [ ! -d "$(pwd)/.ros-root" ]; then
-    echo "ERROR: .ros-root directory is not found" 1>&2
+if [ ! -d "${HOST_INSTALL_ROOT}" ]; then
+    echo "ERROR: System directory is not found" 1>&2


System directory not found

esteve · 2018-04-19T08:17:16Z

install.sh

 fi
 # Set ROS Master URI to ip of which ros is installed (this most probably will te the ros master)
-copy_script="sed -i.bak 's/^\(export\s*ROS_MASTER_URI\s*=\s*\).*$/\http:\/\/$master_ip:11311/' .ros-root/setup_ros1_pepper.bash"
+copy_script="sed -i.bak 's/^\(export\s*ROS_MASTER_URI\s*=\s*\).*$/\http:\/\/$master_ip:11311/' System/setup_ros1_pepper.bash"


${HOST_INSTALL_ROOT}/setup_ros1_pepper.bash

Actually, I think it should be PEPPER_INSTALL_ROOT

esteve · 2018-04-19T08:19:37Z

install.sh

@@ -1,8 +1,10 @@
 #! /bin/bash

+HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System


HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/System"

esteve · 2018-04-19T08:19:45Z

prepare_requirements_ros1.sh

 PYTHON2_VERSION=2.7.13

-INSTALL_ROOT=.ros-root
+HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System


HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/System"

esteve · 2018-04-19T08:19:54Z

prepare_requirements_ros2.sh

@@ -1,11 +1,12 @@
 #!/bin/bash

+HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System


HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/System"

esteve · 2018-04-19T08:21:21Z

build_ros1.sh


-INSTALL_ROOT=.ros-root
+HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System
+PEPPER_INSTALL_ROOT=System


This changes where the ROS files are installed, it should be up to the user to decide, or at least keep the current directory (.ros-root)

fmrico

Changes made:

BASE_ROOT changed to PEPPER_ROS_BASE_ROOT
Updated Readme for removing .root-root
Updated Readme for changing scp by rsync (much faster)

esteve · 2018-04-29T18:34:26Z

@fmrico there's a few conflicts with master, could you rebase? Thanks!

I'm also thinking that using environment variables for setting the destination directory is just too fragile and it should be an argument that is passed to the scripts, what do you think?

esteve · 2018-04-29T18:35:18Z

README.md

+If you want to set the install directory (instead of the project root directory), set the `PEPPER_ROS_BASE_ROOT` environment variable:
+
+```
+export export PEPPER_ROS_BASE_ROOT=/home/mihome/pepper_root/  <-- Or wherever you want


s/export export/export/

fmrico · 2018-05-22T16:50:15Z

@esteve Rebased!!!

Readme updated z# modified: setup_ros2_pepper.bash

fmrico · 2018-05-25T08:49:31Z

@esteve , Comments are applied!

esteve · 2019-02-05T12:08:51Z

README.md

+If you want to set the install directory (instead of the project root directory), set the `PEPPER_ROS_BASE_ROOT` environment variable:
+
+```
+export PEPPER_ROS_BASE_ROOT=/home/mihome/pepper_root/  <-- Or wherever you want


Replace /home/mihome with $HOME

esteve · 2019-02-05T12:09:12Z

README.md


 ```
-$ scp -r .ros-root nao@IP_ADDRESS_OF_YOUR_ROBOT:.ros-root
+$ sync -avz System User nao@pepper.local:~/


rsync instead of sync

esteve · 2019-02-05T12:09:32Z

README.md


 ```
-$ scp -r .ros-root nao@IP_ADDRESS_OF_YOUR_ROBOT:.ros-root
+$ sync -avz System User nao@pepper.local:~/


esteve requested changes Apr 24, 2018

View reviewed changes

fmrico commented Apr 27, 2018

View reviewed changes

esteve requested changes Apr 29, 2018

View reviewed changes

fmrico added 18 commits May 25, 2018 10:24

Select install directory to build

3e86248

BASE_ROOT changed to PEPPER_ROS_BASE_ROOT

188cffc

Readme updated z# modified: setup_ros2_pepper.bash

Typo in readme.md

97903a1

Select install directory to build

6303afa

BASE_ROOT changed to PEPPER_ROS_BASE_ROOT

68b44d2

Readme updated z# modified: setup_ros2_pepper.bash

Typo in readme.md

636ecc2

Select install directory to build

780ed2a

BASE_ROOT changed to PEPPER_ROS_BASE_ROOT

1efd4af

Readme updated z# modified: setup_ros2_pepper.bash

Typo in readme.md

895cb85

Select install directory to build

f151aca

BASE_ROOT changed to PEPPER_ROS_BASE_ROOT

07d4474

Readme updated z# modified: setup_ros2_pepper.bash

Typo in readme.md

be084b5

Env var to BASE_ROOT

87a33a1

Fixed typo in install

7750c4d

Fixed var in install

2d0884e

Fixed var init in build_ros1

0c13bf6

Fixed var init in install

98e3c16

Fixed var init in prepare_reqs_ros1

b36c99d

esteve requested changes Feb 5, 2019

View reviewed changes

fmrico mentioned this pull request Mar 9, 2019

[Feature Request] Workflow for cross compiling custom ROS packages #22

Open

k-okada added a commit to k-okada/ros2_pepper that referenced this pull request Apr 27, 2022

adope @esteve comments from esteve#18

84c925b

k-okada mentioned this pull request Apr 27, 2022

Select install directory to build #30

Open

k-okada added a commit to k-okada/ros2_pepper that referenced this pull request Apr 27, 2022

adopt @esteve comments from esteve#18

e2e73a4

		@@ -1,8 +1,10 @@
		#! /bin/bash

		HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System

		@@ -1,11 +1,12 @@
		#!/bin/bash

		HOST_INSTALL_ROOT="${BASE_ROOT:-${PWD}}/"System

Conversation

fmrico commented Apr 14, 2018

Uh oh!

fmrico commented Apr 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esteve commented Apr 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

esteve Apr 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmrico left a comment

Choose a reason for hiding this comment

Uh oh!

esteve commented Apr 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmrico commented May 22, 2018

Uh oh!

fmrico commented May 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fmrico commented Apr 14, 2018 •

edited

Loading

esteve Apr 19, 2018 •

edited

Loading