Add a new app, the F3 Widget Tuner.#4198
Open
mdoggydog wants to merge 1 commit intoespruino:masterfrom
Open
Conversation
bobrippling
reviewed
Mar 24, 2026
Collaborator
bobrippling
left a comment
bobrippling
left a comment
There was a problem hiding this comment.
LGTM, but some comments
Collaborator
There was a problem hiding this comment.
This should be in your user's gitignore - have a look for "gitignore global" :)
Comment on lines
+1
to
+3
| // This file is part of F3 Widget Tuner. | ||
| // Copyright 2026 Matt Marjanovic <maddog@mir.com> | ||
| // This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with this file, You can obtain one at https://mozilla.org/MPL/2.0/. |
Collaborator
There was a problem hiding this comment.
Do we need a license header in every file?
Also, @gfwilliams are you ok with this license in the repo?
Member
There was a problem hiding this comment.
Discussion at https://github.com/orgs/espruino/discussions/7952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject says it all: adding a new widget-tweaking app to the app catalog.