drained: handle missed "changing" events#4188
Open
bobrippling wants to merge 1 commit intoespruino:masterfrom
Open
drained: handle missed "changing" events#4188bobrippling wants to merge 1 commit intoespruino:masterfrom
bobrippling wants to merge 1 commit intoespruino:masterfrom
Conversation
Collaborator
|
Does this mean something is broken in the event handling somewhere? I mean, why would we be missing to set the interval in the 'charging'-listener? |
Collaborator
|
We also discussed some weird event listener behavior on #4141. Could this be something similar? |
Collaborator
Author
|
Good memory! I would initially say no, and that drained just starts too late but that can't be the case - drained is running when I plug my watch in to charge 🤔 It could well be something with the firmware, like #4141. I'll see if I can get more details |
Collaborator
|
@bobrippling I'm thinking of opening an issue re event handling on espruino/Espruino. Have you managed to understand the problem any more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes my watch will change (with
drainedactive) past the threshold and not deactivatedrained. On debugging, the interval isn't set, so we set it unconditionally to ensure we have a charge "watcher".