-
Notifications
You must be signed in to change notification settings - Fork 1.3k
App Loader: Add dropdowns for sorting and filtering #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
3f00839
6207a03
fe519d2
32b588f
3eb3517
8c3b644
5558f57
87358b1
2df0684
bd05443
c4246d8
4a5697e
da47eee
7d33726
7f8cd74
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,7 +125,22 @@ | |
| border-bottom-right-radius: 1em; | ||
| border-top-right-radius: 1em; | ||
| } | ||
|
|
||
| .menu-item{ | ||
| cursor: pointer; | ||
| } | ||
| .menu .menu-item>a{ | ||
| border-radius: 0.9em; | ||
| padding-left:1em; | ||
| } | ||
| .menu{ | ||
| border-radius: 1em; | ||
| } | ||
| .dropdowns-pill{ | ||
| background-color: rgba(87, 85, 217, 0.066); | ||
| border-radius: 1em; | ||
| padding-left: 1em; | ||
| padding-right: 1em; | ||
| } | ||
| .btn.btn-favourite:focus, | ||
| .btn.btn-favourite:focus-visible, | ||
| .btn-favourite:focus, | ||
|
|
@@ -330,6 +345,22 @@ | |
| .dropdown-container { | ||
| padding-left: 1rem; | ||
| padding-right: 1rem; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 0.75rem; | ||
| flex-wrap: wrap; | ||
| justify-content: center; | ||
| margin-left:0.7em; | ||
| margin-right:0.7em; | ||
| } | ||
|
|
||
| #searchform { | ||
| flex: 1; | ||
| min-width: 450px !important; | ||
| } | ||
|
|
||
| #searchform .form-input { | ||
| width: 100%; | ||
| } | ||
|
|
||
| a.btn.btn-link.dropdown-toggle { | ||
|
|
@@ -386,7 +417,27 @@ | |
| /* stop long text like links pushing the width out too far*/ | ||
| } | ||
|
|
||
| /* Base dropdown alignment */ | ||
| .dropdown { position: relative; } | ||
|
|
||
| .dropdown .menu { | ||
| position: absolute; /* use fixed instead if your parent clips */ | ||
| top: 100%; | ||
| left: 0; | ||
| z-index: 600; | ||
| } | ||
|
|
||
| /* Note: | ||
| Use position: fixed instead of absolute for the dropdown menu | ||
| when its parent or an ancestor has overflow: hidden, auto, | ||
| or scroll and clips the menu. Fixed positioning anchors the | ||
| menu to the viewport so it is not cut off by the clipping | ||
| container, but it will no longer scroll with the parent. */ | ||
| /* Right-align when needed */ | ||
| .dropdown .menu.align-right { | ||
| left: auto; | ||
| right: 0; | ||
| } | ||
|
Comment on lines
+437
to
+440
|
||
| .tile .tile-content br { | ||
| display: block; | ||
| line-height: 100; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,17 +61,66 @@ | |
|
|
||
| <div class="container apploader-tab" id="librarycontainer"> | ||
| <div class="dropdown-container"> | ||
| <div class="dropdown devicetype-nav"> | ||
| <a href="#" class="btn btn-link dropdown-toggle" tabindex="0"> | ||
| <span>All apps</span><i class="icon icon-caret"></i> | ||
| </a> | ||
| <!-- menu component --> | ||
| <ul class="menu"> | ||
| <li class="menu-item"><a>All apps</a></li> | ||
| <li class="menu-item"><a dt="BANGLEJS">Bangle.js 1</a></li> | ||
| <li class="menu-item"><a dt="BANGLEJS2">Bangle.js 2</a></li> | ||
| </ul> | ||
| <div class="dropdowns-pill"> | ||
| <div class="dropdown devicetype-nav"> | ||
| <a href="#" class="btn btn-link dropdown-toggle" tabindex="0"> | ||
| <span>All apps</span><i class="icon icon-caret"></i> | ||
| </a> | ||
| <!-- menu component --> | ||
| <ul class="menu"> | ||
| <li class="menu-item"><a>All apps</a></li> | ||
| <li class="menu-item"><a dt="BANGLEJS">Bangle.js 1</a></li> | ||
| <li class="menu-item"><a dt="BANGLEJS2">Bangle.js 2</a></li> | ||
| </ul> | ||
| </div> | ||
| <div class="dropdown filter-nav"> | ||
| <a href="#" class="btn btn-link dropdown-toggle" tabindex="0"> | ||
| <span>All apps</span><i class="icon icon-caret"></i> | ||
| </a> | ||
| <!-- menu component --> | ||
| <ul class="menu"> | ||
| <li class="menu-item"><a dt="">All apps</a></li> | ||
| <li class="menu-item"><a dt="favourites">Favourites</a></li> | ||
| <li class="menu-item"><a dt="clock">Clocks</a></li> | ||
| <li class="menu-item"><a dt="launch">Launchers</a></li> | ||
| <li class="menu-item"><a dt="game">Games</a></li> | ||
| <li class="menu-item"><a dt="tool">Tools</a></li> | ||
| <li class="menu-item"><a dt="textinput">Keyboards</a></li> | ||
| <li class="menu-item"><a dt="widget">Widgets</a></li> | ||
| <li class="menu-item"><a dt="bluetooth">Bluetooth</a></li> | ||
| <li class="menu-item"><a dt="outdoors">Outdoors</a></li> | ||
| <li class="menu-item"><a dt="ram">Online</a></li> | ||
| <li class="menu-item"><a dt="clkinfo">Clock Info</a></li> | ||
| <li class="menu-item"><a dt="health">Health</a></li> | ||
| <li class="menu-item"><a dt="fonts">Fonts</a></li> | ||
|
Comment on lines
+82
to
+95
|
||
| </ul> | ||
| </div> | ||
| <div class="dropdown sort-nav"> | ||
| <a href="#" class="btn btn-link dropdown-toggle" tabindex="0"> | ||
| <span>Sort by:</span><i class="icon icon-caret"></i> | ||
| </a> | ||
| <!-- menu component --> | ||
| <ul class="menu"> | ||
| <li class="menu-item"><a sortid="">None</a></li> | ||
| <li class="menu-item"><a sortid="created">New</a></li> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The idea of these is that But at least in your app loader (https://rkboss6.github.io/BangleApps) this is now broken - I'm also a bit concerned that we had tooltips on all the items before so that people could hover and see what they actually meant - but you've deleted those? |
||
| <li class="menu-item"><a sortid="modified">Updated</a></li> | ||
| <li class="menu-item"><a sortid="installs">Installed</a></li> | ||
| <li class="menu-item"><a sortid="favourites">Favourited</a></li> | ||
| <li class="menu-item"><a sortid="random">Random</a></li> | ||
| </ul> | ||
| </div> | ||
gfwilliams marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </div> | ||
| <div class="input-group" id="searchform"> | ||
| <input class="form-input" type="text" placeholder="Search by app name, ID, author, or description..."> | ||
| <button class="btn btn-primary input-group-btn">Search</button> | ||
| </div> | ||
| </div> | ||
| <div class="panel" style="clear:both"> | ||
| <div class="panel-header"></div> | ||
| <div class="panel-body columns"><!-- apps go here --></div> | ||
| </div> | ||
| <!-- Old chip-based filtering UI (replaced by dropdowns above). Kept for reference. | ||
|
|
||
| <div class="filter-nav"> | ||
| <label class="chip active" filterid="" data-tooltip="Show all apps">All</label> | ||
| <label class="chip tooltip" filterid="clock" data-tooltip="To tell the time!">Clocks</label> | ||
|
|
@@ -96,17 +145,9 @@ | |
| <label class="chip hidden tooltip" sortid="installs" data-tooltip="Most installed by users">Installed</label> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should really remove this rather than just commenting it out |
||
| <label class="chip hidden tooltip" sortid="favourites" data-tooltip="Most liked by users">Favourited</label> | ||
| </div> | ||
| --> | ||
| </div> | ||
|
|
||
| <div class="panel" style="clear:both"> | ||
| <div class="panel-header"> | ||
| <div class="input-group" id="searchform"> | ||
| <input class="form-input" type="text" placeholder="Keywords..."> | ||
| <button class="btn btn-primary input-group-btn">Search</button> | ||
| </div> | ||
| </div> | ||
| <div class="panel-body columns"><!-- apps go here --></div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="container apploader-tab" id="myappscontainer" style="display:none"> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.