Skip to content

Conversation

@bkovacki
Copy link

Description

The macro ESP_LV_ADAPTER_DISPLAY_SPI_MONO_DEFAULT_CONFIG (defined in components/display/tools/esp_lvgl_adapter/include/esp_lv_adapter_display.h) references a non-existent macro ESP_LV_ADAPTER_DISPLAY_PROFILE_SPI_MONO_DEFAULT_CONFIG.

The correct profile macro exists as ESP_LV_ADAPTER_DISPLAY_PROFILE_MONO_DEFAULT_CONFIG, so this PR renames this profile macro to the macro ESP_LV_ADAPTER_DISPLAY_SPI_MONO_DEFAULT_CONFIG uses.

@github-actions
Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello bkovacki, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2568423

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title fix(lcd): fix profile in ESP_LV_DISPLAY_SPI_MONO_DEFAULT_CONFIG fix(lcd): fix profile in ESP_LV_DISPLAY_SPI_MONO_DEFAULT_CONFIG (AEGHB-1392) Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants