fix unexpected abort (IDFGH-17023)

[safocl]

Description

label cleanup redirect to adc_continuous_deinit() -> adc_apb_periph_free() -- and call unexpected decrement of s_adc_digi_ctrlr_cnt and abort. but the increment of s_adc_digi_ctrlr_cnt was not made. also abort does not allow us to understand what the error was (return is not provided)

esp-idf/components/esp_adc/adc_continuous.c

Line 253 in b6e2de0

adc_continuous_deinit(adc_ctx);

esp-idf/components/esp_adc/adc_continuous.c

Line 174 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 183 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 190 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 197 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 213 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 220 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 226 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 233 in b6e2de0

goto cleanup;

esp-idf/components/esp_adc/adc_continuous.c

Line 448 in b6e2de0

adc_apb_periph_free();

esp-idf/components/esp_hw_support/adc_share_hw_ctrl.c

Line 221 in b6e2de0

void adc_apb_periph_free(void)

Related

Testing

Calling adc_continuous_new_handle with a large max_store_buf_size value on my ESP32 reports the following:

adc_share_hw_ctrl: adc_apb_periph_free called, but s_adc_digi_ctrlr_cnt == 0 abort() was called at PC 0xXXXXXXXX on core 0

(not ESP_ERR_NO_MEM)

---

Checklist

Before submitting a Pull Request, please ensure the following:

• 🚨 This PR does not introduce breaking changes.
• All CI checks (GH Actions) pass.
• Documentation is updated as needed.
• Tests are updated or added as necessary.
• Code is well-commented, especially in complex areas.
• Git history is clean — commits are squashed to the minimum necessary.

---

Note

Fixes error-path cleanup in ADC continuous driver to prevent unintended APB peripheral refcount changes/abort.

• Adds adc_continuous_deinit_light() to free allocated buffers/locks/DMA without calling adc_apb_periph_free()
• Uses this lightweight cleanup in adc_continuous_new_handle() failure path instead of adc_continuous_deinit()

^{Written by Cursor Bugbot for commit d8f7ebd. This will update automatically on new commits. Configure here.}

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "fix(components/adc) unexpected abort": summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello safocl, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against d8f7ebd

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[safocl]

#18068 (comment)
Cursor Bugbot reports that "Memory leak when ringbuffer creation fails" -- does this also apply to the corresponding code in the adc_continuous_deinit() function?

[ginkgm]

Hi @safocl ,

Thanks for your report. the abort is indeed a signal that IDF has a bug rather than the user need to handle something. The error handling code inside new attempt to return some error code. The problem here is the unexpected adc_apb_periph_free call.

We will fix this issue.