Allows require-description to be turned off for specific rules#142
Open
mcongrove wants to merge 2 commits intoeslint-community:mainfrom
Open
Allows require-description to be turned off for specific rules#142mcongrove wants to merge 2 commits intoeslint-community:mainfrom
mcongrove wants to merge 2 commits intoeslint-community:mainfrom
Conversation
Author
|
Hate to ping y'all, but I'm not sure if you were notified this PR was here because I can't request a reviewer. |
Member
|
While there were two thumbs-down, it looks like a potentially useful change to me, and one which fits in with the ESLint approach of allowing projects choice. However, it looks like it will need to be rebased first unless the consensus of the team is against this. Support might also be added for the case where there are multiple rules, e.g., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option to
require-description, calleddisableForRules, which allows you to pass an array of rules thatrequire-descriptionwill not apply to.Example usage:
This can be especially helpful for overrides which are self-evident amongst users of the codebase.
Requested by #134.