Conversation
0cbe43e to
8c3e8c2
Compare
79c0f07 to
4c4ce08
Compare
8c71d15 to
2b95ee3
Compare
Pull Request Test Coverage Report for Build 16405540612Details
💛 - Coveralls |
2b95ee3 to
5b13f5e
Compare
5b13f5e to
a2a0111
Compare
kushti
approved these changes
Jul 7, 2025
0b00af5 to
d272070
Compare
This avoids repeated multiplications by group element when signing
Now that DlogProverInput eagerly evaluates public key, it's a bad fit for ExtSecretKey since it causes unnecessary EC operations
d272070 to
7bd76af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pre-computed multiplication tables for generator where possible (secret key -> pk, generating public image of nonce in signing/verification, etc). Also pre-compute DlogProverInput.public_image() to avoid repeated EC operations in signing (helps performance when there are many secrets in Wallet).
Some benchmarks (Wallet with 1000 secrets, signing N inputs):
Some small improvements to verification as well, tested on dbd86fdce57f3a5124e88ec1ee4b7289e450e059e21a74c303bf13bf0b924945, time to verify is down from 0.2s to 0.17s