Make observation localization radius defaulted on config creation#13289
Merged
xjules merged 1 commit intoequinor:mainfrom Apr 10, 2026
Merged
Make observation localization radius defaulted on config creation#13289xjules merged 1 commit intoequinor:mainfrom
xjules merged 1 commit intoequinor:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13289 +/- ##
==========================================
- Coverage 90.00% 89.98% -0.03%
==========================================
Files 457 457
Lines 31581 31585 +4
==========================================
- Hits 28426 28422 -4
- Misses 3155 3163 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eivindjahren
approved these changes
Apr 10, 2026
In order to be able to hash the localization shapes correctly, the radius needs to be set on the config creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #13273
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable