Skip to content

Make observation localization radius defaulted on config creation#13289

Merged
xjules merged 1 commit intoequinor:mainfrom
xjules:default_radius
Apr 10, 2026
Merged

Make observation localization radius defaulted on config creation#13289
xjules merged 1 commit intoequinor:mainfrom
xjules:default_radius

Conversation

@xjules
Copy link
Copy Markdown
Contributor

@xjules xjules commented Apr 10, 2026

Issue
Resolves #13273

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@xjules xjules self-assigned this Apr 10, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (9a43f3a) to head (6f1f7ae).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13289      +/-   ##
==========================================
- Coverage   90.00%   89.98%   -0.03%     
==========================================
  Files         457      457              
  Lines       31581    31585       +4     
==========================================
- Hits        28426    28422       -4     
- Misses       3155     3163       +8     
Flag Coverage Δ
cli-tests 37.47% <100.00%> (-0.01%) ⬇️
fuzz 44.52% <100.00%> (-0.01%) ⬇️
gui-tests 67.16% <100.00%> (-0.03%) ⬇️
performance-and-unit-tests 77.93% <100.00%> (-0.01%) ⬇️
test 46.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/config/_create_observation_dataframes.py 90.90% <ø> (-0.12%) ⬇️
src/ert/config/_observations.py 95.48% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

In order to be able to hash the localization shapes correctly, the
radius needs to be set on the config creation.
@xjules xjules changed the title Make observation localization defaulted on config creation Make observation localization radius defaulted on config creation Apr 10, 2026
@xjules xjules enabled auto-merge (rebase) April 10, 2026 12:42
@xjules xjules merged commit e538b28 into equinor:main Apr 10, 2026
44 checks passed
@xjules xjules deleted the default_radius branch April 10, 2026 13:31
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 10, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing xjules:default_radius (6f1f7ae) with main (7c245db)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default localization radius during config creation instead of dataframe stage

3 participants