EverestObjectiveFunctionPlot and EverestControlsPlot improvements

[eilskra]

Issue
Resolves #13266
Resolves #13265

Approach

Added 4 different line-styles to the EverestControlsPlot, using PlotConfig.getNumberOfColors() to determine when to change line style. Set the LEGEND_THRESHOLD to 5 controls as pr the other plots.

16 controls toggled, 4 different line styles. No legend

5 controls toggled, so legend is showing

Moved nextColor() outside of for-loop for single color(unless number of realizations < 5), but keeps potential future color-palette changes, in ObjectiveFunctionPlot

More than 5 realizations

Less than 5 realizations, includes different colors and legend

• PR title captures the intent of the changes, and is fitting for release notes.
• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.
• Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

• When there are user facing changes: Updated documentation
• New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
• Large PR: Prepare changes in small commits for more convenient review
• Bug fix: Add regression test for the bug
• Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (18d2e71) to head (cc76f62).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...tools/plot/plottery/plots/everest_controls_plot.py	0.00%	12 Missing ⚠️
.../plottery/plots/everest_objective_function_plot.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13283      +/-   ##
==========================================
- Coverage   90.00%   89.95%   -0.05%     
==========================================
  Files         457      457              
  Lines       31551    31596      +45     
==========================================
+ Hits        28397    28422      +25     
- Misses       3154     3174      +20     

Flag	Coverage Δ
cli-tests	37.46% <0.00%> (+0.03%)	⬆️
fuzz	44.50% <0.00%> (-0.06%)	⬇️
gui-tests	67.10% <0.00%> (-0.07%)	⬇️
performance-and-unit-tests	77.90% <0.00%> (-0.07%)	⬇️
test	46.19% <0.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../plottery/plots/everest_objective_function_plot.py	21.62% <0.00%> (-0.61%)	⬇️
...tools/plot/plottery/plots/everest_controls_plot.py	19.14% <0.00%> (-5.18%)	⬇️

... and 3 files with indirect coverage changes

[codspeed-hq]

Merging this PR will not alter performance

✅ 36 untouched benchmarks

---

_{Comparing eilskra:plot-improvements (cc76f62) with main (7c245db)}

[berland]

Nicer!