Merged
Conversation
eprbell
reviewed
Jan 13, 2026
Owner
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
This LGTM: do you mind fixing the two static analysis errors (not code you changed, I know) so as to pacify the linter? They should be just simple removals. Thanks.
Contributor
|
I have the static analysis errors fixed in #299 and https://github.com/eprbell/dali-rp2/pull/299/files#diff-4d89de56a7a8051f1646d28bd2864c995c6e3fc509e413d21aa1dd297309d86d |
macanudo527
force-pushed
the
deep-wiki-ai-link
branch
from
2a9786f to
4ba3b74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as eprbell/rp2#145 but for dali