Optimisation: Replacing listView in CarSelectionActivity with Recycler View having well designed Cardviews#1012
Merged
SebaDro merged 3 commits intoenviroCar:developfrom Jan 6, 2025
Conversation
SebaDro
requested changes
Jan 3, 2025
org.envirocar.app/res/layout/activity_car_selection_layout_carlist_entry.xml
Show resolved
Hide resolved
SebaDro
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This activity presently contains listView for showing the list of cars which is not an efficient approach.
This listView needs to be replaced with RecyclerView having well-designed CardViews which will lead to a better user interface as well as better app performance.
How did it get fixed?
Replace ListView with RecyclerView, Create
CarSelectionRecyclerAdapterformCarRecyclerViewCreate a function & method that is also required in
CarSelectionListAdapter. Also added CardView for a better user experience.Conclusion
Now,
CarSelectionActivityuses RecyclerView, That better for App performance. Also Solved Broken car selection radio button #927Reviews
I like to invite @SebaDro to review this PR and give me suggestions