Enso supports evaluation with arguments by JaroslavTulach · Pull Request #14739 · enso-org/enso

JaroslavTulach · 2026-02-09T07:17:06Z

Pull Request Description

allow foreign enso functions - not very useful itself but good for testing and explaining the concepts
- demonstrates Enso complies to Truffle standards for passing arguments to languages
the core use case is to write GraalVM Insight scripts
- to make it any useful we need to be able to import - done in df4108a
shall work with Use enso.dev.insight properly to turn Insight on #11385

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

All code follows the
Scala,
Java,
Unit tests have been written where possible.

…thArguments

JaroslavTulach · 2026-02-18T06:48:06Z

engine/runtime/src/main/java/org/enso/interpreter/node/WithArgsRootNode.java

+
+      var imports =
+          originalSrc.lines().takeWhile(isImportStatement).collect(Collectors.joining("\n"));
+


This kind of string splitting and concatenation is far from perfect

from a parser perspective this is a ridiculous attempt

but it gets the job done for now

What's needed?

Enso code snippets without imports are not very useful except REPL

hence we need to be able to import ... and from ... import ...

Coding without data structures is hard as well

hence we may need an ability to specify new type in the snippet

It can all be done with intrinsic string manipulation ...

but maybe there is a way to do this in TreeToIr, what do you think @kazcw?

A question first: What do the source locations look like?

Foreign-function based: Source locations would be within the "file" constructed from the foreign function's string (I think this is what the current implementation does)

Host-module based: Source locations reflected the source code in the module. This might be more helpful for debugging. It also makes the IR more "compatible" for reuse, see below.

So, there are different ways to approach making things from the "host" module visible in the "foreign" module:

string operations before parsing the foreign module (as in this current implementation)

IR operations after parsing the foreign module. This could be very simple and efficient. The main issue is source references. The IR we would want to copy has host-module based locations; if the new source has foreign-function based locations, we can't just mix them (Unless IR knows its origin file somehow? But source references are just line:column). If we assign host-module based locations to everything, then combining the newly parsed "module" with parts of the host module is straightforward.

semantic operations: I could imagine the imports and type definitions being "executed" just once, to populate some sort of environment, within which functions from the host module, including foreign functions, could be run. But I don't know what would be involved in doing it that way, this is in later compiler/runtime stages than I am familiar with at all.

What do the source locations look like?

while working on this PR I discovered some problems with source locations

evaluation of Debug.eval was using incorrect source file

it used the source that contained Debug.eval

rather the source of the code snippet

sometimes (when the snippet was longer than original file) that might even lead to exceptions

I improved the situation in c43d4e7

I should probably separate that to its own PR with a test...

done in Avoid invalid source section bounds error in Debug.eval #14784

Foreign-function based: Source locations would be within the "file" constructed from the foreign

Yes, that's the approach for foreign functions

Done in Debug JavaScript/Python in Enso Source #9440

the foreign source is constructed to match the lines of the original code

so the foreign function appears to have code locations in the original file

IR operations after parsing the foreign module. This could be very simple and efficient. The main issue is source references. .... If we assign host-module based locations to everything, then combining the newly parsed "module" with parts of the host module is straightforward.

I think the biggest problem of this PR is that there are "two sources"

one defining lambda which does imports and then invokes Debug.eval

the other one is expression body send as an argument to Debug.eval

Can we merge the two sources together into one? Isn't the expression body parsed in some special way (expression only)? I think it is:

enso/engine/runtime-parser/src/main/java/org/enso/compiler/core/EnsoParser.java

Line 33 in 761b716

var tree = Parser.parseBlock(src);

how can we keep the current semantics of parseBlock ...

but also have import and type definitions in the same source?

do we need some changes in the Rust parser code, @kazcw?

another thought: Do we want to change the syntax to allow this kind of expression body in .enso file?

because if one follows the Insight in Enso tutorial one gets a file like this:

our existing VSCode/NetBeans support marks that file as syntactically incorrect!

…rror reporter

…r 'unknown type_of for [n, acc]'))

JaroslavTulach · 2026-02-19T13:27:06Z

Insight in Enso Manual

Builds on top of Insight & Enso Manual that required use of JavaScript. This manual is fully relying on Enso language.

Create Insight Script

Simple script to start with is for example methods.js:

from Standard.Base import all

IO.println "Initializing Insight: "+(Meta.type_of insight).to_text

calling ctx frame =
    IO.println "Calling "+ctx.name

when = Dictionary.empty
    . insert "roots" True
    . insert "rootNameFilter" ".*main.*"

insight.on "enter" calling when

The insight variable is automatically provided. Learn more about writing Insight Scripts:

GraalVM Insight Manual
GraalVM Insight API docs

Usage in CLI

Execute either a script:

sbt:enso> runEngineDistribution --vm.D=enso.dev.insight=methods.enso --run test/Base_Tests Nic
Initializing Insight: (Error: (Compile_Error.Error 'unknown type_of for com.oracle.truffle.tools.agentscript.impl.AgentObject@710afd47'))
Calling enso_dev.Base_Tests.Main::enso_dev.Base_Tests.Main::main
Calling Main.main.suite
Calling Suite_Config.find_caller_script.find_main
Calling Suite_Config.find_caller_script.find_main
Calling Suite_Config.find_caller_script.find_main
Calling Suite_Config.find_caller_script.find_main


0 tests succeeded.
0 tests failed.
0 tests skipped.
0 groups skipped.

4e6 · 2026-02-19T13:56:40Z

engine/runtime/src/main/java/org/enso/interpreter/node/WithArgsRootNode.java

+      var originalSrc = src.getCharacters().toString();
+
+      Predicate<String> isImportStatement =
+          (line) -> line.startsWith("import ") || line.startsWith("from ") || line.trim().isEmpty();


Why an empty line is considered an import statement deserves a comment

Also, probably a good idea to always do line.trim() in case of misaligned/malformed code

this kind of "source manipulation" is the most fragile part of this PR

I put the check for empty line there because:

it is common to separate imports into group in our code, for example:

enso/test/Base_Tests/src/Runtime/Ref_Spec.enso

Lines 1 to 6 in 0008bcf

from Standard.Base import all

import Standard.Base.Errors.Illegal_Argument.Illegal_Argument

import Standard.Base.Runtime.Ref.Ref

from Standard.Test import all

always do line.trim()

space before from Standard.Base import all is a syntax error

this all shows that doing IR manipulations (as discussed with Keziah) would be the preferred option

4e6 · 2026-02-19T14:05:22Z

engine/runtime/src/main/java/org/enso/interpreter/node/WithArgsRootNode.java

+      var lambdaArgs = argNames.stream().collect(Collectors.joining("-> "));
+      var lambdaCode =
+          """
+          import Standard.Base


Assumption that Standard.Base is always available deserves a comment. Can we make eval a builtin?

Debug.eval is a builtin - but it still needs to be imported

as written here Enso supports evaluation with arguments #14739 (comment) this approach with "two sources" may be the root of the problem

however it is the only one that is known to solve the issue of "evaluation with arguments" right now

- extracted from #14739 - source locations for reports of errors in `Debug.eval` scripts were wrong

Enso supports evaluation with arguments

2325347

JaroslavTulach self-assigned this Feb 9, 2026

JaroslavTulach requested review from 4e6, AdRiley, hubertp and jdunkerley as code owners February 9, 2026 07:17

JaroslavTulach added 3 commits February 9, 2026 12:17

Using var

d0ffc54

Rename self argument

af327e3

Insight test written in Enso

35fc14d

JaroslavTulach marked this pull request as draft February 9, 2026 11:50

JaroslavTulach added 4 commits February 18, 2026 05:34

Merge remote-tracking branch 'origin/develop' into wip/jtulach/EvalWi…

a1ac233

…thArguments

First argument is name of action

370760b

Observe loading of files test

5fbb729

Use locally activated Insight scripts

486285d

JaroslavTulach requested a review from kazcw February 18, 2026 06:14

Snippets need imports support to be any useful

df4108a

JaroslavTulach commented Feb 18, 2026

View reviewed changes

JaroslavTulach added 7 commits February 18, 2026 13:47

InlineContext has to be able to provide own (interactive) Source to e…

c43d4e7

…rror reporter

Yields expected self to be Array, but got (Error: (Compile_Error.Erro…

ba56826

…r 'unknown type_of for [n, acc]'))

javafmt

2a67ec9

TruffleObject with hasArrayElements is recognized as Array

88b27e1

Keep exception stack trace

e11add4

Trace local variables in Enso

1fed436

All tests pass now

5189b84

JaroslavTulach added -compiler CI: No changelog needed Do not require a changelog entry for this PR. labels Feb 18, 2026

JaroslavTulach marked this pull request as ready for review February 18, 2026 16:42

JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Feb 19, 2026

JaroslavTulach mentioned this pull request Feb 19, 2026

Avoid invalid source section bounds error in Debug.eval #14784

Merged

2 tasks

Fixing compilation errors

eb07540

JaroslavTulach mentioned this pull request Feb 19, 2026

Use enso.dev.insight properly to turn Insight on #11385

Merged

3 tasks

Recognize files with .enso extension

d5b2d0e

4e6 approved these changes Feb 19, 2026

View reviewed changes

mergify bot pushed a commit that referenced this pull request Feb 20, 2026

Avoid invalid source section bounds error in Debug.eval (#14784)

eed9766

- extracted from #14739 - source locations for reports of errors in `Debug.eval` scripts were wrong

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Enso supports evaluation with arguments#14739

Enso supports evaluation with arguments#14739
JaroslavTulach wants to merge 18 commits intodevelopfrom
wip/jtulach/EvalWithArguments

JaroslavTulach commented Feb 9, 2026 •

edited

Loading

Uh oh!

JaroslavTulach Feb 18, 2026 •

edited

Loading

Uh oh!

kazcw Feb 18, 2026 •

edited

Loading

Uh oh!

JaroslavTulach Feb 19, 2026 •

edited

Loading

Uh oh!

JaroslavTulach Feb 19, 2026 •

edited

Loading

Uh oh!

JaroslavTulach Feb 19, 2026 •

edited

Loading

Uh oh!

JaroslavTulach commented Feb 19, 2026 •

edited

Loading

Uh oh!

4e6 Feb 19, 2026

Uh oh!

4e6 Feb 19, 2026

Uh oh!

JaroslavTulach Feb 19, 2026

Uh oh!

4e6 Feb 19, 2026

Uh oh!

JaroslavTulach Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		var imports =
		originalSrc.lines().takeWhile(isImportStatement).collect(Collectors.joining("\n"));

	from Standard.Base import all

	import Standard.Base.Errors.Illegal_Argument.Illegal_Argument
	import Standard.Base.Runtime.Ref.Ref

	from Standard.Test import all

Comments

Conversation

JaroslavTulach commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Important Notes

Checklist

Uh oh!

JaroslavTulach Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kazcw Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Insight in Enso Manual

Create Insight Script

Usage in CLI

Uh oh!

4e6 Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

4e6 Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

4e6 Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JaroslavTulach commented Feb 9, 2026 •

edited

Loading

JaroslavTulach Feb 18, 2026 •

edited

Loading

kazcw Feb 18, 2026 •

edited

Loading

JaroslavTulach Feb 19, 2026 •

edited

Loading

JaroslavTulach Feb 19, 2026 •

edited

Loading

JaroslavTulach Feb 19, 2026 •

edited

Loading

JaroslavTulach commented Feb 19, 2026 •

edited

Loading