Skip to content

Commit 958b761

Browse files
authored
Merge pull request #44 from tamslinn/master
Don't cache requests, try to Fix #27
2 parents 05d0dbb + 8e158b4 commit 958b761

File tree

2 files changed

+22
-8
lines changed

2 files changed

+22
-8
lines changed

app/src/main/java/org/emoncms/myapps/HTTPClient.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public RequestQueue getRequestQueue() {
3030
// getApplicationContext() is key, it keeps you from leaking the
3131
// Activity or BroadcastReceiver if someone passes one in.
3232
mRequestQueue = Volley.newRequestQueue(mCtx.getApplicationContext());
33+
mRequestQueue.getCache().clear();
3334
}
3435
return mRequestQueue;
3536
}
@@ -41,6 +42,7 @@ public void cancellAll(String TAG) {
4142
}
4243

4344
public <T> void addToRequestQueue(Request<T> req) {
45+
req.setShouldCache(false);
4446
req.setRetryPolicy(new DefaultRetryPolicy(2500, 0, 1f));
4547
getRequestQueue().add(req);
4648
}

app/src/main/java/org/emoncms/myapps/chart/PowerChart.java

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public PowerChart(LineChart powerChart, Context context) {
3838
chartValues = new ArrayList<>();
3939

4040
setFormatting();
41-
powerData = createDataSet();
41+
powerData = createData();
4242

4343
}
4444

@@ -58,7 +58,7 @@ public void clearData() {
5858
}
5959

6060
public void setChartLength(int length) {
61-
powerData = createDataSet();
61+
powerData = createData();
6262
powerChartLength = length;
6363
requiresReset = true;
6464
}
@@ -91,6 +91,11 @@ public void refreshChart() {
9191

9292
LineDataSet dataSet = (LineDataSet) powerData.getDataSetByLabel("watts", true);
9393
dataSet.clear();
94+
//powerData.clearValues();
95+
//powerData.addDataSet(createDataSet());
96+
97+
98+
9499

95100
for (int i = 0; i < chartLabels.size(); i++) {
96101

@@ -144,7 +149,16 @@ private boolean validNonNullSavedData(List<String> savedChartLabels, double[] sa
144149

145150

146151

147-
private LineData createDataSet() {
152+
private LineData createData() {
153+
LineDataSet powerDataset = createDataSet();
154+
155+
LineData ld = new LineData();
156+
ld.addDataSet(powerDataset);
157+
powerChart.setData(ld);
158+
return ld;
159+
}
160+
161+
private LineDataSet createDataSet() {
148162
LineDataSet powerDataset = new LineDataSet(null, "watts");
149163
powerDataset.setColor(ContextCompat.getColor(context, R.color.chartBlue));
150164
powerDataset.setValueTextColor(ContextCompat.getColor(context, R.color.lightGrey));
@@ -154,12 +168,10 @@ private LineData createDataSet() {
154168
powerDataset.setDrawValues(false);
155169
powerDataset.setValueTextSize(R.integer.chartValueTextSize);
156170
powerDataset.setHighlightEnabled(false);
157-
LineData ld = new LineData();
158-
ld.addDataSet(powerDataset);
159-
powerChart.setData(ld);
160-
return ld;
171+
return powerDataset;
161172
}
162-
173+
174+
163175
private void setFormatting() {
164176
powerChart.setDrawGridBackground(false);
165177
powerChart.getLegend().setEnabled(false);

0 commit comments

Comments
 (0)