Add timeout-nodismiss config option and unread tracking#639
Open
HollowPhobos wants to merge 1 commit intoemersion:masterfrom
Open
Add timeout-nodismiss config option and unread tracking#639HollowPhobos wants to merge 1 commit intoemersion:masterfrom
HollowPhobos wants to merge 1 commit intoemersion:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When notifications expire via timeout, they move to history indistinguishably from notifications the user explicitly dismissed. There's no way for external tools (waybar modules, scripts) to know whether the user actually saw and interacted with a notification.
This problem exists independently from adding
mode=awayfrom outside of mako.Solution
Add a
timeout-nodismissboolean style option. When enabled, notifications that expire via timeout are moved to history with an unread flag. Explicitly dismissed notifications do not get this flag.timeout-nodismiss=0|1(per-style, criteria-compatible)makoctl history -j output(field is omitted when false — zero output change for users who don't enable the feature)makoctl mark-read [-n id] [-a|--all]command to clear the unread flagUsage
In config set a timeout and enable timeout-nodismiss
View unread notifications
makoctl history -j | jq '[.[] | select(.unread == true)]'Mark all as read
makoctl mark-read -aMark one as read
makoctl mark-read -n 42Design notes
unread=truewhen reason isEXPIREDandtimeout-nodismissis enabledmako(5)andmakoctl(1)