move ember debug tests into own app by patricklx · Pull Request #2642 · emberjs/ember-inspector

patricklx · 2025-05-21T20:42:51Z

ember debug is the thing that should/can be tested with older ember versions.
for inspector ui its not required. we can extend it for it as well though.

ember_debug_test_app/tests/helpers/setup-ember-debug-test.js

BlueCutOfficial · 2025-05-28T16:03:08Z

Since this PR changes the usage of ember-try in the repo, I would be tempted to add ember-lts-5.12 to the configuration (and it's green locally ✅) IMO that could be a good iteration before investigating 6.x in a later PR :)

ember_debug_test_app/app/services/adapters/basic.js

ember_debug_test_app/app/services/adapters/web-extension.js

ember_debug_test_app/ember-cli-build.js

patricklx · 2025-06-01T17:37:39Z

ember_debug_test_app/tests/index.html

+    <script src="{{rootURL}}assets/vendor.js"></script>
+    <script src="{{rootURL}}assets/test-support.js"></script>
+    <script src="{{rootURL}}assets/test-app.js"></script>
+    <script src="{{rootURL}}ember_debug.js"></script>


here we inject ember debug into the test app

ember_debug/utils/ember.js

BlueCutOfficial

To be fair I don't understand 100% all the details of all the changes so I would use at least one second opinion (cc @mansona) but this iteration looks fine IMO. The general approach to separate UI tests and ember_debug tests makes sense to me + fixing all the ember-try scenarios recreates more confidence in the test suite.

(Purely on the form, I think enabling 6+ and fixing 3.16~3.24 could have been done in 2 separated PRs, but I woundn't consider this a blocker since the commit stack is clean)

BlueCutOfficial · 2025-06-26T09:29:04Z

Hi @patricklx, I've an update about this PR.

@mansona has initiated a task to improve the "start wrapper" part of the inspector, based on his work on Rollup. This would enable the possibility of importing an adapter, so we wouldn't have to re-implement an adapter in each test app. We suggest keeping the present PR on hold until Chris has finished that work, then we can rebase and include this improvement.

ember_debug/rollup.config.js

patricklx · 2025-10-07T14:17:07Z

test-apps/tests/helpers/mock-basic-adapter.js

a copy of inspector-ui app service to setup communication with ember-debug

patricklx · 2025-10-07T14:18:19Z

test-apps/tests/helpers/mock-web-extension-adapter.js

a copy of inspector-ui app service to setup communication with ember-debug

can we use the code directly from the inspector?
otherwise are we testing much of the inspector?

All the tests are separate for ui and ember_debug

ef4 · 2025-10-07T15:46:27Z

@BlueCutOfficial @mansona has this addressed the previous comment about rebasing on the other adapter work?

.github/workflows/build.yml

NullVoxPopuli · 2026-03-02T16:05:00Z

ember_debug/utils/version.js

  let operator = specifier[0];
  if (Number.isNaN(+operator)) {
    specifier = specifier.slice(1);
+  } else {


what's this for?

was a leftover from local testing, but i will make another PR for it.

test-apps/classic/ember-cli-build.js

NullVoxPopuli · 2026-03-02T16:15:48Z

@patricklx from DMs with @mansona -- @mansona says that we probably don't want new adapters -- some things got extracted to a real package which should help clean things up (I dunno what this means rn, but hopefully it makes sense)

patricklx · 2026-03-02T21:29:26Z

@patricklx from DMs with @mansona -- @mansona says that we probably don't want new adapters -- some things got extracted to a real package which should help clean things up (I dunno what this means rn, but hopefully it makes sense)

I am not sure what this is about. I did not add new adapters to ember _debug.
I only copied an adapter from inspector ui part to the test app. Because ember_debug needs that.

Remove commented eslint disable line and adjust formatting.

- Created mock-basic-adapter.js with singleton pattern - Created mock-web-extension-adapter.js with singleton pattern - Updated test-adapter.js to extend MockBasicAdapter - Updated injection-test.js to use getMockWebExtensionAdapter() - Original adapters kept in place as they are required for injection tests

patricklx force-pushed the split-out-ember-debug-tests branch from ea8f7dd to c38d0f0 Compare May 22, 2025 08:24

patricklx requested a review from RobbieTheWagner May 22, 2025 11:24

BlueCutOfficial reviewed May 28, 2025

View reviewed changes

ember_debug_test_app/tests/helpers/setup-ember-debug-test.js Outdated Show resolved Hide resolved

BlueCutOfficial reviewed May 28, 2025

View reviewed changes

ember_debug_test_app/tests/helpers/setup-ember-debug-test.js Outdated Show resolved Hide resolved

patricklx mentioned this pull request May 29, 2025

test ember 5.8 and 5.12 #2643

Merged

patricklx force-pushed the split-out-ember-debug-tests branch 4 times, most recently from 1df0de2 to 24127a0 Compare May 30, 2025 20:48

patricklx closed this May 31, 2025

patricklx reopened this May 31, 2025

patricklx force-pushed the split-out-ember-debug-tests branch from ed1d1b6 to f15771c Compare June 1, 2025 15:39

patricklx closed this Jun 1, 2025

patricklx reopened this Jun 1, 2025

patricklx force-pushed the split-out-ember-debug-tests branch from ae33cb7 to b085545 Compare June 1, 2025 16:44

patricklx commented Jun 1, 2025

View reviewed changes

ember_debug_test_app/app/services/adapters/basic.js Show resolved Hide resolved

patricklx commented Jun 1, 2025

View reviewed changes

ember_debug_test_app/app/services/adapters/web-extension.js Show resolved Hide resolved

patricklx commented Jun 1, 2025

View reviewed changes

ember_debug_test_app/ember-cli-build.js Outdated Show resolved Hide resolved

patricklx commented Jun 1, 2025

View reviewed changes

patricklx force-pushed the split-out-ember-debug-tests branch 4 times, most recently from de7b45d to c238b51 Compare June 2, 2025 08:08

patricklx changed the title ~~move ember debug tests into own app~~ move ember debug tests into own app & fix tests Jun 2, 2025

BlueCutOfficial reviewed Jun 3, 2025

View reviewed changes

ember_debug/utils/ember.js Outdated Show resolved Hide resolved

patricklx force-pushed the split-out-ember-debug-tests branch 2 times, most recently from 7d97550 to 2bf5316 Compare June 3, 2025 10:08

BlueCutOfficial approved these changes Jun 3, 2025

View reviewed changes

patricklx requested a review from mansona June 4, 2025 07:38

BlueCutOfficial self-requested a review June 25, 2025 07:37

patricklx force-pushed the split-out-ember-debug-tests branch from 6659f91 to 850d0a8 Compare June 25, 2025 07:37

patricklx mentioned this pull request Jun 25, 2025

add ember static source test app #2665

Open

patricklx force-pushed the split-out-ember-debug-tests branch from 850d0a8 to a13f486 Compare October 6, 2025 21:17

patricklx commented Oct 7, 2025

View reviewed changes

ember_debug/rollup.config.js Outdated Show resolved Hide resolved

patricklx commented Oct 7, 2025

View reviewed changes

patricklx force-pushed the split-out-ember-debug-tests branch 3 times, most recently from a5cfae1 to f673d10 Compare October 7, 2025 14:29

patricklx force-pushed the split-out-ember-debug-tests branch from f673d10 to 019b6f0 Compare February 26, 2026 08:50

move ember debug tests into own app

a3020a0

patricklx force-pushed the split-out-ember-debug-tests branch from 019b6f0 to a3020a0 Compare February 26, 2026 08:52

NullVoxPopuli reviewed Mar 2, 2026

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

NullVoxPopuli reviewed Mar 2, 2026

View reviewed changes

test-apps/classic/ember-cli-build.js Show resolved Hide resolved

remove symlink

3b57336

patricklx and others added 9 commits March 3, 2026 10:30

revert

2edf4df

keep only versions.js

0c4dd1d

fix

1431cd9

Remove commented eslint disable line and adjust formatting.

fix lint

bc72ad6

fix lint

bdcbf8d

fix

da7c062

fix

0183172

fix

9e9abf5

Conversation

patricklx commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BlueCutOfficial commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patricklx Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BlueCutOfficial left a comment

Choose a reason for hiding this comment

Uh oh!

BlueCutOfficial commented Jun 26, 2025

Uh oh!

Uh oh!

patricklx Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

patricklx Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

patricklx Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

ef4 commented Oct 7, 2025

Uh oh!

Uh oh!

NullVoxPopuli Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

patricklx Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NullVoxPopuli commented Mar 2, 2026

Uh oh!

patricklx commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

patricklx commented May 21, 2025 •

edited

Loading