Skip to content

Replace eslint-plugin-node with eslint-plugin-n #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ef4 merged 1 commit into from
Mar 28, 2025
Merged

Replace eslint-plugin-node with eslint-plugin-n #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ module.exports = {
parserOptions: {
ecmaVersion: 2017,
},
plugins: ['node', 'prettier'],
extends: ['eslint:recommended', 'plugin:node/recommended', 'plugin:prettier/recommended'],
plugins: ['n', 'prettier'],
extends: ['eslint:recommended', 'plugin:n/recommended', 'plugin:prettier/recommended'],
env: {
node: true,
},
Expand All @@ -19,7 +19,7 @@ module.exports = {
jest: true,
},
rules: {
'node/no-unpublished-require': 'off',
'n/no-unpublished-require': 'off',
},
},
{
Expand All @@ -34,13 +34,9 @@ module.exports = {
],
rules: {
'prefer-const': 'off',
'node/no-unsupported-features/es-syntax': [
'error',
{
ignores: ['modules'],
},
],
'node/no-missing-import': 'off',

// this rule doesn't really support modern node ESM
'n/no-missing-import': 'off',

'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"ember-source": "^6.4.0-beta.1",
"eslint": "^8.57.0",
"eslint-config-prettier": "^6.15.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^17.17.0",
"eslint-plugin-prettier": "^5.1.3",
"jest": "^29.3.1",
"prettier": "^3.3.2",
Expand Down
109 changes: 68 additions & 41 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/node-main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ export type Options = Omit<SharedOptions, 'transforms' | 'compiler'> & {

async function cwdImport(moduleName: string) {
let target = importMetaResolve(moduleName, pathToFileURL(process.cwd() + sep).href);

// TODO
// eslint-disable-next-line
return esCompat(await import(target));
}

Expand Down