Skip to content

Don't try to auto-detect ember template compiler when targetFormat do… #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ef4 merged 1 commit into from
Mar 26, 2025
Merged

Don't try to auto-detect ember template compiler when targetFormat do… #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node-main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function handleNodeSpecificOptions(opts: Options): Promise<SharedOptions>
} else if (opts.compiler) {
assertTemplateCompiler(opts.compiler);
compiler = opts.compiler;
} else {
} else if (opts.targetFormat === 'wire') {
let mod: any = await cwdImport('ember-source/dist/ember-template-compiler.js');
assertTemplateCompiler(mod);
compiler = mod;
Expand Down
4 changes: 1 addition & 3 deletions src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,7 @@ function normalizeOpts(options: Options): NormalizedOpts {
if ((options.targetFormat ?? 'wire') === 'wire') {
let { compiler } = options;
if (!compiler) {
throw new Error(
`when targetFormat==="wire" you must set the compiler or compilerPath option`
);
throw new Error(`when targetFormat==="wire" you must provide the ember template compiler`);
}
return {
outputModuleOverrides: {},
Expand Down