fix: show full-screen email view on mobile instead of split panel#1983
Open
shubsolos19 wants to merge 2 commits intoelie222:mainfrom
Open
fix: show full-screen email view on mobile instead of split panel#1983shubsolos19 wants to merge 2 commits intoelie222:mainfrom
shubsolos19 wants to merge 2 commits intoelie222:mainfrom
Conversation
…ie222#342) On mobile, Mail and Reply Zero were rendering a vertical split panel instead of a full-screen view, making both panels too small to use. Changes: - EmailList.tsx: on mobile, show full-screen email detail with a ← Back button instead of a vertical ResizablePanelGroup split - ReplyTrackerEmails.tsx: same fix applied to Reply Zero Fixes elie222#342
On mobile, Reply Zero was rendering a vertical split panel instead of a full-screen view, making both panels too small to use. Replaced vertical ResizablePanelGroup with full-screen detail view and a ← Back button on mobile.
|
@shubsolos19 is attempting to deploy a commit to the Inbox Zero OSS Program Team on Vercel. A member of the Team first needs to authorize it. |
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/components/email-list/EmailList.tsx">
<violation number="1" location="apps/web/components/email-list/EmailList.tsx:483">
P2: Mobile full-screen detail still shows the global bulk-action toolbar, undermining the intended full-screen layout.</violation>
<violation number="2" location="apps/web/components/email-list/EmailList.tsx:483">
P2: Mobile detail view unmounts the email list, causing scroll-position loss when returning to the list.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| if (!right) return left; | ||
|
|
||
| // ── Mobile: full-screen detail with a Back button ────────────────── | ||
| if (isMobile) { |
Contributor
There was a problem hiding this comment.
P2: Mobile full-screen detail still shows the global bulk-action toolbar, undermining the intended full-screen layout.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/components/email-list/EmailList.tsx, line 483:
<comment>Mobile full-screen detail still shows the global bulk-action toolbar, undermining the intended full-screen layout.</comment>
<file context>
@@ -490,16 +469,39 @@ export function EmailList({
if (!right) return left;
+ // ── Mobile: full-screen detail with a Back button ──────────────────
+ if (isMobile) {
+ return (
+ <div className="flex h-full flex-col overflow-hidden">
</file context>
| if (!right) return left; | ||
|
|
||
| // ── Mobile: full-screen detail with a Back button ────────────────── | ||
| if (isMobile) { |
Contributor
There was a problem hiding this comment.
P2: Mobile detail view unmounts the email list, causing scroll-position loss when returning to the list.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/components/email-list/EmailList.tsx, line 483:
<comment>Mobile detail view unmounts the email list, causing scroll-position loss when returning to the list.</comment>
<file context>
@@ -490,16 +469,39 @@ export function EmailList({
if (!right) return left;
+ // ── Mobile: full-screen detail with a Back button ──────────────────
+ if (isMobile) {
+ return (
+ <div className="flex h-full flex-col overflow-hidden">
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile, Mail and Reply Zero were rendering a vertical split panel
instead of a full-screen view, making both panels too small to use.
Changes:
button instead of a vertical ResizablePanelGroup split
Fixes #342