Skip to content

Remove flawed MSC4311 partial implementation: Client-side API's like /sync should still use stripped events#19723

Draft
MadLittleMods wants to merge 2 commits intodevelopfrom
madlittlemods/remove-flawed-msc4311-partial-implementation
Draft

Remove flawed MSC4311 partial implementation: Client-side API's like /sync should still use stripped events#19723
MadLittleMods wants to merge 2 commits intodevelopfrom
madlittlemods/remove-flawed-msc4311-partial-implementation

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Apr 23, 2026

Remove flawed MSC4311 partial implementation: Client side API's like /sync should still use stripped events.

This was originally introduced in 0eb7252 (no PR I assume because part of Hydra security fix)

Spawning from reviewing #19722 and noticing that we have TestMSC4311FullCreateEventOnStrippedState in Complement which already passes even though that test looks flawed:

I think this test is mixing up what MSC4311 proposes. Perhaps these were changes to the MSC that came after?

For the client API's like /sync, it only proposes that m.room.create is a required stripped state event.

For the federation API's, alongside requiring m.room.create, it also mandates using the full event PDU format for all events in the invite_room_state/knock_room_state on m.room.member events (in unsigned)


Part of #19414

Todo

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@MadLittleMods MadLittleMods changed the title Client side API's like /sync should still use stripped events with MSC4311 Remove flawed MSC4311 partial implementation: Client side API's like /sync should still use stripped events Apr 23, 2026
@MadLittleMods MadLittleMods changed the title Remove flawed MSC4311 partial implementation: Client side API's like /sync should still use stripped events Remove flawed MSC4311 partial implementation: Client-side API's like /sync should still use stripped events Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant