Remove flawed MSC4311 partial implementation: Client-side API's like /sync should still use stripped events#19723
Draft
MadLittleMods wants to merge 2 commits intodevelopfrom
Conversation
/sync should still use stripped events with MSC4311/sync should still use stripped events
/sync should still use stripped events/sync should still use stripped events
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove flawed MSC4311 partial implementation: Client side API's like
/syncshould still use stripped events.This was originally introduced in 0eb7252 (no PR I assume because part of Hydra security fix)
Spawning from reviewing #19722 and noticing that we have
TestMSC4311FullCreateEventOnStrippedStatein Complement which already passes even though that test looks flawed:Part of #19414
Todo
TestMSC4311FullCreateEventOnStrippedStateComplement test so it doesn't look for the full PDU in/sync.Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.