Feat/screenshare app audio sharing#33044
Open
JoaoCostaIFG wants to merge 4 commits intoelement-hq:developfrom
Open
Feat/screenshare app audio sharing#33044JoaoCostaIFG wants to merge 4 commits intoelement-hq:developfrom
JoaoCostaIFG wants to merge 4 commits intoelement-hq:developfrom
Conversation
Integrate @vencord/venmic for application audio capture during screen sharing on Linux via PipeWire. - Add audio picker dialog for selecting apps/system audio to share - Support both Wayland (native portal) and X11 (Electron picker) paths - Inject getDisplayMedia patch for Element Call iframe compatibility - Build venmic as a hak native module dependency - Add Compound Design Tokens for audio picker UI theming
Remove duplicate package declarations for matrix-seshat and @vencord/venmic that were already managed via hakDependencies. The optionalDependencies, pnpm overrides, and root dependencies entries were unnecessary duplicates causing build complexity. Also re-add New Vector Ltd. copyright to displayMediaCallback.ts. Signed-off-by: JoaoCostaIFG <[email protected]>
…and iframe injection - Extract shared patch logic into venmic-patch.ts - preload.cts now imports and calls applyVenmicPatch() - venmic-inject.ts now imports VENMIC_PATCH_SCRIPT constant - Add cleanup handlers (stopVenmic) in iframe injection when window.electron is available - Document cross-origin iframe limitation where venmic cannot auto-stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Description
Will help implement the feature requested in this issue: element-hq/element-call #3657.
Problems
pnpm run hakwill fail on non-linux systems:Next steps (outside the scope of this PR)
Screenshots
Audio sharing app picker: