Update SpotlightDialog.tsx#31613
Closed
manthan2325 wants to merge 1 commit intoelement-hq:developfrom
Closed
Conversation
|
|
github-actions
bot
added
the
Z-Community-PR
Author
|
HI @weeman1337 could you please add the T-enhancement label to my PR so the checks can pass ? Thanks ! |
t3chguy
requested changes
Jan 2, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
You must describe your change. Your title offers no insight and you have no PR description.
| const onDialogKeyDown = (ev: KeyboardEvent | React.KeyboardEvent): void => { | ||
| const key = (ev as KeyboardEvent).key; | ||
| // handle PageUp / PageDown to scroll the results container by one page | ||
| if (key === "PageDown" || key === "PageUp") { |
Member
There was a problem hiding this comment.
This should be using the keybinding stack as below
Member
|
Closing due to no response from author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.