http2: set ServerName for upstream TLS client#761
Open
germanescobar wants to merge 1 commit intoelazarl:masterfrom
Open
http2: set ServerName for upstream TLS client#761germanescobar wants to merge 1 commit intoelazarl:masterfrom
germanescobar wants to merge 1 commit intoelazarl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, we are using goproxy for a sandbox platform that we are building and found this issue that we had to patch in our project, so I asked Codex to help me open this PR:
This fixes an HTTP/2 MITM failure in
H2Transport.RoundTrip()when the TLS config used for the upstream client connection does not already includeServerName.Before this change, the H2 path could fail with:
tls: either ServerName or InsecureSkipVerify must be specified in the tls.ConfigThe root issue is that
RoundTrip()reusesr.TLSConfigas a client TLS config, but that config is often created for the server-side MITM role and may not yet be valid for upstream client verification.This change:
h2ServerNamefrom the upstream host when it is missingI hit this while testing Git smart-HTTP over HTTPS with downstream HTTP/2 enabled through the proxy.