Add no_proxy support for HTTPS CONNECT requests#750
Open
jcrussell wants to merge 1 commit intoelazarl:masterfrom
Open
Add no_proxy support for HTTPS CONNECT requests#750jcrussell wants to merge 1 commit intoelazarl:masterfrom
jcrussell wants to merge 1 commit intoelazarl:masterfrom
Conversation
When https_proxy is set, HTTPS CONNECT requests now respect the no_proxy environment variable by checking http.ProxyFromEnvironment() before dialing through the upstream proxy. If the destination matches no_proxy, the connection is made directly. Also removes TestHttpProxyAddrsFromEnv which is redundant with TestGoproxyThroughProxy and was potentially flaky with no_proxy settings. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that no_proxy wasn't been used -- worked after applying this patch.
When https_proxy is set, HTTPS CONNECT requests now respect the no_proxy environment variable by checking http.ProxyFromEnvironment() before dialing through the upstream proxy. If the destination matches no_proxy, the connection is made directly.
Also removes TestHttpProxyAddrsFromEnv which is redundant with TestGoproxyThroughProxy and was potentially flaky with no_proxy settings.