Skip to content

Conversation

@alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Dec 5, 2025

Summary

Related issue #243094
Follow up to this PR #242791 - naming request updated.

This PR is part of the work to support multiple managed LLMs. This PR moves away from generic naming and updates names for preconfigured connectors.

Because these configurations are in yaml files, the connector id cannot use a period without escaping it.
There seems to be way to escape special chars by using something like preconfigured.["sonnet-3.7"].actionTypeId but it hasn't been used so far in kibana and would need to be tested.

Given the time sensitive nature of this change, I updated the id and replaced the period with a dash in the PRs. E.g. Anthropic-Claude-Sonnet-3.7 becomes Anthropic-Claude-Sonnet-3-7
From what I can see in kibana, there is no logic depending on the id to match the name exactly so this solution should be fine.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Dec 5, 2025
@alvarezmelissa87 alvarezmelissa87 requested review from a team as code owners December 5, 2025 20:42
@alvarezmelissa87 alvarezmelissa87 added the backport:skip This PR does not require backporting label Dec 5, 2025
@alvarezmelissa87 alvarezmelissa87 requested review from a team as code owners December 5, 2025 20:42
@alvarezmelissa87 alvarezmelissa87 added the ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project label Dec 5, 2025
@alvarezmelissa87 alvarezmelissa87 requested review from a team as code owners December 5, 2025 20:42
@alvarezmelissa87 alvarezmelissa87 added the ci:project-deploy-observability Create an Observability project label Dec 5, 2025
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner December 5, 2025 20:42
@alvarezmelissa87 alvarezmelissa87 added ci:project-deploy-security Create a Security Serverless Project Feature:Inference UI ML Inference endpoints UI and AI connector labels Dec 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana Security is co-codeowner on the serverless yml files primarily to intercept and review feature privilege changes. Approving to unblock and deferring to owning teams for review.

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 7, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.1MB 11.1MB +10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
elasticAssistant 307.5KB 307.5KB +5.0B

History

cc @alvarezmelissa87

Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defend workflows ok

'General-Purpose-LLM-v1',
'General-Purpose-LLM-v2',
'General-Purpose-LLM-v3',
'Anthropic-Claude-Sonnet-3-7',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a central place we can define this as a constant and import it into the Solutions code, so updates only require a single change rather than multiple edits across the codebase?

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let’s follow up by moving the connector definition into a shared constant so future updates touch fewer places.

@alvarezmelissa87 alvarezmelissa87 merged commit 5226ed1 into elastic:main Dec 8, 2025
12 checks passed
@alvarezmelissa87 alvarezmelissa87 deleted the preconfig-connector-rename branch December 8, 2025 18:19
mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 8, 2025
* commit '6647f813c9fa03ac0378e3d4756246e8dc4b4c76': (33 commits)
  [Detection Engine] Extracts Rules/Alerts/Exceptions permission to new Rules feature privileges (elastic#239634)
  [Agent Builder] Add Intro Tour (elastic#245551)
  Add datastream lifecycle support to indices metadata (elastic#245548)
  [Serverless] Update preconfigured connectors (elastic#245445)
  [Metrics][Discover] Discover to prefer line chars for time series data (elastic#244595)
  Update dependency @elastic/ebt to ^1.4.1 (main) (elastic#241629)
  [One Workflow] fix: request bodies with oneof schemas (`kibana.SetAlertsStatus`, etc) (elastic#245344)
  Update dependency ai to v5 (elastic#244675)
  Fix Discover trace waterfall behavior with duplicate spans (elastic#244984)
  [FSH] Migrated fs usage to kbn/fs for sample ingest (elastic#244163)
  Streamlang: Unskip type coercion test (elastic#245519)
  [Response Ops][Reporting] Fixing error in calculating delay value between retries (elastic#245431)
  Add TopNavMenuBeta to navigation plugin (elastic#243578)
  [scout] support custom servers configuration (elastic#244306)
  [Fleet] Run agentless background sync without dry run (elastic#245286)
  Fix Change Password Flaky Test (elastic#245443)
  Add new gap fill status for rules (elastic#242595)
  [Kibana Search] Move SLOs higher up in search results (elastic#245518)
  feat(slo): introduce find SLO instances internal route (elastic#245333)
  [FSH] Dropped unnecessary `fs` persistence for synthetics project code (elastic#244338)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project Feature:Inference UI ML Inference endpoints UI and AI connector :ml release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants