-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Serverless] Update preconfigured connectors #245445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Update preconfigured connectors #245445
Conversation
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
seanstory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeramysoucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana Security is co-codeowner on the serverless yml files primarily to intercept and review feature privilege changes. Approving to unblock and deferring to owning teams for review.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
Samiul-TheSoccerFan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defend workflows ok
| 'General-Purpose-LLM-v1', | ||
| 'General-Purpose-LLM-v2', | ||
| 'General-Purpose-LLM-v3', | ||
| 'Anthropic-Claude-Sonnet-3-7', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a central place we can define this as a constant and import it into the Solutions code, so updates only require a single change rather than multiple edits across the codebase?
stephmilovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let’s follow up by moving the connector definition into a shared constant so future updates touch fewer places.
* commit '6647f813c9fa03ac0378e3d4756246e8dc4b4c76': (33 commits) [Detection Engine] Extracts Rules/Alerts/Exceptions permission to new Rules feature privileges (elastic#239634) [Agent Builder] Add Intro Tour (elastic#245551) Add datastream lifecycle support to indices metadata (elastic#245548) [Serverless] Update preconfigured connectors (elastic#245445) [Metrics][Discover] Discover to prefer line chars for time series data (elastic#244595) Update dependency @elastic/ebt to ^1.4.1 (main) (elastic#241629) [One Workflow] fix: request bodies with oneof schemas (`kibana.SetAlertsStatus`, etc) (elastic#245344) Update dependency ai to v5 (elastic#244675) Fix Discover trace waterfall behavior with duplicate spans (elastic#244984) [FSH] Migrated fs usage to kbn/fs for sample ingest (elastic#244163) Streamlang: Unskip type coercion test (elastic#245519) [Response Ops][Reporting] Fixing error in calculating delay value between retries (elastic#245431) Add TopNavMenuBeta to navigation plugin (elastic#243578) [scout] support custom servers configuration (elastic#244306) [Fleet] Run agentless background sync without dry run (elastic#245286) Fix Change Password Flaky Test (elastic#245443) Add new gap fill status for rules (elastic#242595) [Kibana Search] Move SLOs higher up in search results (elastic#245518) feat(slo): introduce find SLO instances internal route (elastic#245333) [FSH] Dropped unnecessary `fs` persistence for synthetics project code (elastic#244338) ...
Summary
Related issue #243094
Follow up to this PR #242791 - naming request updated.
This PR is part of the work to support multiple managed LLMs. This PR moves away from generic naming and updates names for preconfigured connectors.
Because these configurations are in yaml files, the connector id cannot use a period without escaping it.
There seems to be way to escape special chars by using something like
preconfigured.["sonnet-3.7"].actionTypeIdbut it hasn't been used so far in kibana and would need to be tested.Given the time sensitive nature of this change, I updated the id and replaced the period with a dash in the PRs. E.g.
Anthropic-Claude-Sonnet-3.7becomesAnthropic-Claude-Sonnet-3-7From what I can see in kibana, there is no logic depending on the id to match the name exactly so this solution should be fine.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.