crowdstrike: improvements and fixes to ingest pipelines for all data streams#16730
Conversation
ba57063 to
c98679a
Compare
c98679a to
c507690
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| formats: | ||
| - UNIX | ||
| tag: date_event_start_time_epoch | ||
| tag: date_event_end_time_epoch |
There was a problem hiding this comment.
Can we have a different tag for this one than above?
There was a problem hiding this comment.
Thanks! Fixed both issues and also cleaned up duplicate tags across other pipeline files.
There was a problem hiding this comment.
Did you use any script for updating the tags?
I think its easier to review the script instead of reviewing all changes in latest commit.
There was a problem hiding this comment.
No script was used. I made the changes manually. Mostly the changes followed a pattern:
added _ms suffix for UNIX_MS date format tags, added descriptive suffix to foreach processors, fixed other duplicate tags due to copy paste error.
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
| tag: rename_child_process_ids | ||
| target_field: crowdstrike.alert.child_process_ids | ||
| ignore_missing: true | ||
| - rename: |
There was a problem hiding this comment.
This processor is redundant.
| formats: | ||
| - UNIX | ||
| tag: date_event_start_time_epoch | ||
| tag: date_event_end_time_epoch |
There was a problem hiding this comment.
Thanks! Fixed both issues and also cleaned up duplicate tags across other pipeline files.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
Package crowdstrike - 3.2.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/3.2.0/ |
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Pipeline Tests for all data streams:
Related issues
Screenshots