Skip to content

[EuiFlyout] Missing flyout title in screen reader announcement #9212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexwizp wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[EuiFlyout] Missing flyout title in screen reader announcement #9212

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f4b420
[EuiFlyout] Missing flyout title in screen reader announcement
alexwizp Nov 13, 2025
cf1e0e5
fix Cypress
alexwizp Nov 14, 2025
86f35fd
changelog
alexwizp Nov 14, 2025
c311d63
remove tabIndex
alexwizp Nov 21, 2025
aa0f37f
try to remove data-autofocus
alexwizp Nov 24, 2025
9b9f615
add tabIndex to header
alexwizp Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/9212.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Accessibility**

- Changed the close button position in `EuiFlyout` to allow for the modal title to be perceivable first
4 changes: 2 additions & 2 deletions packages/eui/src/components/flyout/flyout.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ describe('EuiFlyout', () => {
it('traps focus and cycles tabbable items', () => {
cy.mount(<Flyout />);
cy.get('[data-test-subj="flyoutSpec"]').should('be.focused');
cy.repeatRealPress('Tab', 4);
cy.get('[data-test-subj="itemC"]').should('be.focused');
cy.repeatRealPress('Tab', 3);
cy.get('[data-test-subj="itemC"]').should('be.focused');
cy.repeatRealPress('Tab', 2);
cy.get('[data-test-subj="euiFlyoutCloseButton"]').should('be.focused');
});

Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/flyout/flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,9 @@ export const EuiFlyout = forwardRef(
aria-describedby={!isPushed ? ariaDescribedBy : _ariaDescribedBy}
data-autofocus={!isPushed || undefined}
>
{contentToRender}
{!isPushed && screenReaderDescription}
{closeButton}
{contentToRender}
</Element>
</EuiFocusTrap>
</EuiFlyoutWrapper>
Expand Down
2 changes: 1 addition & 1 deletion packages/eui/src/components/tool_tip/tool_tip.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe('EuiToolTip', () => {

cy.get('[data-test-subj="flyout"]').focus();

cy.repeatRealPress('Tab', 2);
cy.repeatRealPress('Tab', 1);
cy.get('[data-test-subj="tool_tip"]').should('exist');

cy.realPress('Escape');
Expand Down