chatbot-rag-app: removes unnecessary parts of Docker build#406
Merged
codefromthecrypt merged 2 commits intomainfrom Mar 4, 2025
Merged
chatbot-rag-app: removes unnecessary parts of Docker build#406codefromthecrypt merged 2 commits intomainfrom
codefromthecrypt merged 2 commits intomainfrom
Conversation
Contributor
Author
|
moved the parts not about the entrypoint to this PR meanwhile #407 |
Contributor
Author
|
when elastic/elastic-otel-python-instrumentations#54 is released, we should be good to go here |
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
codefromthecrypt
force-pushed
the
chatbot-rag-app-docker
branch
from
e590639 to
83253bd
Compare
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
Contributor
Author
|
ok I tried this both ways, enabled and disabled. no worries. I can't try k8s because the docker image is pushed only after this change. However, it should work. |
anuraaga
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the temporary workaround for the OTEL_SDK_DISABLED variable