-
Notifications
You must be signed in to change notification settings - Fork 209
[9.2] (backport #11724) Use google/go-containerregistry to parse OCI images in packaging tests #12498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+70
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#11724) * Use google/go-containerregistry to parse OCI images in packaging tests * Use docker/go-units Co-authored-by: Shaunak Kashyap <[email protected]> * Add import * Update beats submodule * go mod tidy --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit 44814ff) # Conflicts: # go.mod # go.sum
Contributor
Author
|
Cherry-pick of 44814ff has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
3 tasks
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
swiatekm
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
chore
Tasks that just need to be done, they are neither bug, nor enhancements
conflicts
There is a conflict in the backported pull request
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the google/go-containerregistry package to parse container tarballs in package tests, instead of parsing them manually. The tests now pass for images exported from the containerd image store.
Why is it important?
The current code only handles one container archive format. In particular, it doesn't handle exports from the containerd snapshotter, which docker enables by default for new installations as of v29.0. After the change, both formats are supported. We currently ship our tarballs using the older format, but eventually want to switch to the newer one. This change will also make package tests pass locally for new docker installs.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Build a container image with the containerd image store enabled and run package tests via
mage testPackages.Related issues
This is an automatic backport of pull request #11724 done by [Mergify](https://mergify.com).