Fix type of "this" parameter in generic method body#48
Open
fcurdi wants to merge 1 commit intoedgardozoppi:metadata-providerfrom
Open
Fix type of "this" parameter in generic method body#48fcurdi wants to merge 1 commit intoedgardozoppi:metadata-providerfrom
fcurdi wants to merge 1 commit intoedgardozoppi:metadata-providerfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extracting a method, the field Parameters contains the
thisparameter if it is not static, but its type is the generic method (not instantiated). This is changed to the the instantiation of that method with its generic parameters. This means that if a method is within a typeSomeTypethat has generic parameterT, in the method bodythisshould be of that type but instantiated with the generic parameterT.