Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #251 +/- ##
===========================================
+ Coverage 66.33% 66.38% +0.04%
===========================================
Files 1126 1127 +1
Lines 57668 57776 +108
Branches 4403 4407 +4
===========================================
+ Hits 38253 38353 +100
- Misses 19415 19423 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ozaq
reviewed
Jan 28, 2026
Member
Ozaq
left a comment
Ozaq
left a comment
There was a problem hiding this comment.
Can you please provide a commit message with some context
Comment on lines
+359
to
+361
| custom.set("area", std::vector<double>{north(), west(), south(), east()}); | ||
| if (operator!=(bounding_box_default())) { | ||
| custom.set("area", std::vector<double>{north(), west(), south(), east()}); | ||
| } |
Member
There was a problem hiding this comment.
This looks a bit suspicious: Why does fill_spec not set the area on the spec if the BoundingBox itself is default?
pmaciel
force-pushed
the
feature/eckit-geo
branch
from
014b724 to
ce9eb0f
Compare
pmaciel
force-pushed
the
feature/eckit-geo
branch
3 times, most recently
from
531dbb5 to
034c686
Compare
pmaciel
force-pushed
the
feature/eckit-geo
branch
2 times, most recently
from
23111e5 to
d2dc3ea
Compare
pmaciel
force-pushed
the
feature/eckit-geo
branch
3 times, most recently
from
e259b16 to
b92bde4
Compare
pmaciel
force-pushed
the
feature/eckit-geo
branch
from
e8cc3e1 to
1954e11
Compare
pmaciel
force-pushed
the
feature/eckit-geo
branch
from
1954e11 to
46d8c7c
Compare
pmaciel
force-pushed
the
feature/eckit-geo
branch
from
46d8c7c to
d2ac56a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-251