Fix FSDP issues when "random" forecast policies are used#2128
Open
SavvasMel wants to merge 2 commits intoecmwf:developfrom
Open
Fix FSDP issues when "random" forecast policies are used#2128SavvasMel wants to merge 2 commits intoecmwf:developfrom
SavvasMel wants to merge 2 commits intoecmwf:developfrom
Conversation
clessig
reviewed
Mar 29, 2026
| worker_info = torch.utils.data.get_worker_info() | ||
| worker_id = worker_info.id if worker_info is not None else 0 | ||
| forecast_seed = self._base_rng_seed * ((worker_id + 1) * 37) * (self.mini_epoch + 13) * 7 | ||
| forecast_rng = np.random.default_rng(forecast_seed) |
Collaborator
There was a problem hiding this comment.
Shouldn't this be a class variable that is initialized in the constructor?
| # worker_workset seed formula is used to but exclude the rank component. | ||
| worker_info = torch.utils.data.get_worker_info() | ||
| worker_id = worker_info.id if worker_info is not None else 0 | ||
| forecast_seed = self._base_rng_seed * ((worker_id + 1) * 37) * (self.mini_epoch + 13) * 7 |
Collaborator
There was a problem hiding this comment.
We use this formula twice (also at the bottom of the file). Please put into a small function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two changes:
Issue Number
Closes #1984
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60