Skip to content

Remove method arc_alpha#1825

Open
TillHae wants to merge 1 commit intoecmwf:developfrom
TillHae:thauer/develop/issue_1819
Open

Remove method arc_alpha#1825
TillHae wants to merge 1 commit intoecmwf:developfrom
TillHae:thauer/develop/issue_1819

Conversation

@TillHae
Copy link
Contributor

@TillHae TillHae commented Feb 7, 2026

Description

arc_alpha is defined in tokenizer_utils.py and in utils.py. Both methods are the same and both are never used throughout the entire repo.

Through this PR the method is removed from tokenizer_utils.py and utils.py.

Issue Number

Closes #1819

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Method arc_alpha defined two times

1 participant