Small refactoring for EmbeddingEngine #1467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andom and healpix masking. Open issues with _coords_local, centroids and probably other things.
TODO: - Forecast still needs to be adapted - Some more cleanup of variable naming, return values etc
…e. Unclear how to deal with it with MTM
…enizer_masking. generate the mask, otherwise using batchify_source and batchify_target as before, with the capacity to remember what mask we have now when it comes to generating the targets. Update to inputs_metadata structure but not put in to practice
…ing overall structure
…eatherGenerator into shmh40/dev/1270-idx-global-local
…eanup needed but overall program flow working
* Add to device to ModelBatch, etc & adapt model TODO adapt validate and inference TODO test forecasting and multiple stream because predict changed substantially * Rename view to sample and fix validate * Revert predict function and fix inference * Fix invalid access with mask * Linting * Fixed handling of target_idxs and other minor issues * Remove duplicate to_device * move loss history into loss calculator * handle loss_avg and unflatten loss dict * fixing train_logger * update validate logging, failing - need to merge data branch * rm additional log files and log_vals variable, and collapse to single add_logs fct for train and val * rm comment * fix validation * move prepare losses fct to train_logger script, fix terminal logging for val * fix ctr_loss_fcts normalization; calculate per stream, per lfct average across channels and fsteps for logging * Fixed linting * fix bug in emptying history after logging --------- Co-authored-by: sophiex <[email protected]> Co-authored-by: Christian Lessig <[email protected]>
Collaborator
|
Can we do this against this branch: shmh40/dev/1270-idx-global-local, see #1283 |
TillHae
changed the base branch from
main
to
shmh40/dev/1270-idx-global-local
TillHae
force-pushed
the
pr-refactoring
branch
from
b173e17 to
c1bd1a2
Compare
Contributor
Author
I hope everything worked out. This made most of my changes obsolete. |
Collaborator
|
TillHae
changed the base branch from
shmh40/dev/1270-idx-global-local
to
develop
Contributor
Author
|
Closing this PR and doing a new cleaner one |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[EmbeddingEngine](https://github.com/ecmwf/WeatherGenerator/blob/develop/src/weathergen/model/engines.py#L110)for efficiency.Issue Number
Fixes #1466
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60