Add .tmp.cfg to top-level gitignore#17377
Merged
colin-grant-work merged 1 commit intomasterfrom Apr 23, 2026
Merged
Conversation
f00a6b1 to
c671625
Compare
ndoschek
approved these changes
Apr 23, 2026
Member
ndoschek
left a comment
There was a problem hiding this comment.
Thank you @colin-grant-work, LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds
.tmp.cfgto the root.gitignoreso that the temporary config directory created by the Playwrighttheia:startscript is ignored regardless of where it lands.Prior to the yarn-to-npm migration in #14481 (0036769), the script used
yarn --cwd ../browser start, which didn't change the shell's working directory.$PWDstill pointed atexamples/playwright/, so.tmp.cfgwas created there and covered byexamples/playwright/.gitignore.The npm migration replaced
yarn --cwdwithcd ../browser && npm run start, which shifts$PWDtoexamples/browser/before$PWDis evaluated. A subsequent fix in #16455 (c895e74) movedrimrafafter thecdso cleanup and creation were consistent, but both now targetexamples/browser/— leaving an untracked.tmp.cfgthat the existing.gitignoredoesn't cover.Rather than reworking the script (npm has no cross-platform equivalent of
yarn --cwd), this PR simply adds.tmp.cfgto the root.gitignore.How to test
npm run test:playwrightfrom the repository root (ornpm run ui-testsfromexamples/playwright/).git statusno longer shows an untrackedexamples/browser/.tmp.cfg/entry.Follow-ups
The
examples/playwright/.gitignoreentry for.tmp.cfgis now redundant but harmless. It could be removed in a follow-up.Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers