Skip to content

Add .tmp.cfg to top-level gitignore#17377

Merged
colin-grant-work merged 1 commit intomasterfrom
chore/update-gitignore
Apr 23, 2026
Merged

Add .tmp.cfg to top-level gitignore#17377
colin-grant-work merged 1 commit intomasterfrom
chore/update-gitignore

Conversation

@colin-grant-work
Copy link
Copy Markdown
Contributor

What it does

Adds .tmp.cfg to the root .gitignore so that the temporary config directory created by the Playwright theia:start script is ignored regardless of where it lands.

Prior to the yarn-to-npm migration in #14481 (0036769), the script used yarn --cwd ../browser start, which didn't change the shell's working directory. $PWD still pointed at examples/playwright/, so .tmp.cfg was created there and covered by examples/playwright/.gitignore.

The npm migration replaced yarn --cwd with cd ../browser && npm run start, which shifts $PWD to examples/browser/ before $PWD is evaluated. A subsequent fix in #16455 (c895e74) moved rimraf after the cd so cleanup and creation were consistent, but both now target examples/browser/ — leaving an untracked .tmp.cfg that the existing .gitignore doesn't cover.

Rather than reworking the script (npm has no cross-platform equivalent of yarn --cwd), this PR simply adds .tmp.cfg to the root .gitignore.

How to test

  1. Run npm run test:playwright from the repository root (or npm run ui-tests from examples/playwright/).
  2. Verify that git status no longer shows an untracked examples/browser/.tmp.cfg/ entry.

Follow-ups

The examples/playwright/.gitignore entry for .tmp.cfg is now redundant but harmless. It could be removed in a follow-up.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation Bot moved this to Waiting on reviewers in PR Backlog Apr 20, 2026
@colin-grant-work colin-grant-work changed the title Put Playwright run configs in Playwright directory Add .tmp.cfg to top-level gitignore Apr 20, 2026
Copy link
Copy Markdown
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @colin-grant-work, LGTM 👍

@github-project-automation github-project-automation Bot moved this from Waiting on reviewers to Needs merge in PR Backlog Apr 23, 2026
@colin-grant-work colin-grant-work merged commit bcf49ef into master Apr 23, 2026
16 of 17 checks passed
@colin-grant-work colin-grant-work deleted the chore/update-gitignore branch April 23, 2026 14:59
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Apr 23, 2026
@github-actions github-actions Bot added this to the 1.71.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants