fix(tree): prevent node expansion when double-clicking checkbox#17372
Open
YueCHEN195 wants to merge 1 commit intoeclipse-theia:masterfrom
Open
fix(tree): prevent node expansion when double-clicking checkbox#17372YueCHEN195 wants to merge 1 commit intoeclipse-theia:masterfrom
YueCHEN195 wants to merge 1 commit intoeclipse-theia:masterfrom
Conversation
cef4ab5 to
dec8595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Currently, in the
TreeWidget, rapid consecutive clicks (a double-click) on a node's checkbox will bubble up to the tree node row. Because the checkbox only stops the propagation ofonClickbut notonDoubleClick, thehandleDblClickEventof the tree row is triggered. This results in the unintended behavior where double-clicking a checkbox causes the tree node to expand or collapse.This PR fixes the issue by adding an
onDoubleClickevent handler to the checkbox<input>element inrenderCheckboxand callinge.stopPropagation(). This ensures that double-click events on the checkbox are consumed by the checkbox itself and do not trigger the tree node's default expansion/collapse behavior.How to test
TreeWidgetwith checkboxes enabled (i.e., nodes returning validcheckboxInfo).Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers