Conversation
- Add all activation events from current VS Code docs and real extensions that were missing from BUILTIN_ACTIVATION_EVENTS - The missing prefixes caused noisy "Unsupported activation events" warnings in the console Contributed on behalf of STMicroelectronics
Resolves GH-17365 Contributed on behalf of STMicroelectronics
- update nls metadata for VSCode API 1.116.0 - fix suggestions to use nls.localizeByDefault or replace removed defaults Contributed on behalf of STMicroelectronics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Resolves GH-17365
nls.localizeByDefaultor replace removed defaultsBUILTIN_ACTIVATION_EVENTSonChatParticipant,onEditSession,onIssueReporterOpened,onLanguageModelTool,onOpenExternalUri,onProfile,onRenderer,onSearch,onTerminal,onTerminalShellIntegration,onTunnel,onWalkthroughNo public API changes:
src/vscode-dts/vscode.d.tsis unchanged between 1.110.1 and 1.116.0, so notheia.d.tsupdates are required this cycle. Proposed API and menu evolutions are tracked in GH-17365.How to test
Unsupported activation eventswarnings appear on startup for the newly-added prefixesFollow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers