Prevent illegal array size when constructing menu bar#17362
Open
colin-grant-work wants to merge 3 commits intomasterfrom
Open
Prevent illegal array size when constructing menu bar#17362colin-grant-work wants to merge 3 commits intomasterfrom
colin-grant-work wants to merge 3 commits intomasterfrom
Conversation
cdamus
approved these changes
Apr 20, 2026
Contributor
cdamus
left a comment
cdamus
left a comment
There was a problem hiding this comment.
Looks good to me! I do have a nit to offer.
github-project-automation
Bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
cdamus
approved these changes
Apr 20, 2026
Contributor
cdamus
left a comment
cdamus
left a comment
There was a problem hiding this comment.
Works just as well and looks more tasty. Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #17352 by overriding the
clearMenumethod of the dynamic menu bar to reset state tracking fields that go stale otherwise. If the values are stale, Lumino will attempt to constructnew Array(-1), leading to an error and a broken menu.How to test
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers