Use withServices to detect early Monaco initialization#17361
Open
colin-grant-work wants to merge 1 commit intomasterfrom
Open
Use withServices to detect early Monaco initialization#17361colin-grant-work wants to merge 1 commit intomasterfrom
colin-grant-work wants to merge 1 commit intomasterfrom
Conversation
38838f5 to
978c4be
Compare
cdamus
approved these changes
Apr 23, 2026
Contributor
cdamus
left a comment
There was a problem hiding this comment.
Does the job! I do have a nit for you to consider if you're keen.
Comment on lines
+242
to
+243
| const serviceCollection: ServiceCollection | undefined = instantiationService?._services; | ||
| if (serviceCollection) { |
Contributor
There was a problem hiding this comment.
nit: If for whatever reason the private _services changes in a future release then serviceCollection may end up falsy. If we think we need to patch services but we don't get the collection we expect, then we silently fail to do anything. We should probably check that we got a ServicesCollection of the correct shape and log if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #17245 by using a targeted check to detect whether Monaco services had been initialized before our call to
StandaloneServices.initializeHow to test
StandaloneServices.initialize, you should see thatisInitializedistrueandservicesInitializedBeforeOverridesisfalse, since we have then initialized the services, but they hadn't been initialized before our call.Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers