Skip to content

Fix EditorSwitchTest opening external terminals #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 1 commit into from
Jan 7, 2026
Merged

Fix EditorSwitchTest opening external terminals #3642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/org.eclipse.ui.tests.performance/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
name="Editor w/Outline"
id="org.eclipse.ui.tests.perf_outline"
extensions="perf_outline"/>
<editor
icon="icons/anything.gif"
class="org.eclipse.ui.tests.performance.parts.PerformanceEditorPart"
default="true"
name="Basic Performance Editor 2"
id="org.eclipse.ui.tests.perf_basic2"
extensions="perf_text"/>
</extension>
<extension
point="org.eclipse.ui.perspectives">
Expand Down
2 changes: 1 addition & 1 deletion ...g.eclipse.ui.tests.performance/src/org/eclipse/ui/tests/performance/EditorSwitchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class EditorSwitchTest extends PerformanceTestCaseJunit4 {

@Parameters(name = "{index}: {0} - {1}")
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][] { { "perf_outline", "java" }, { "perf_basic", "perf_outline" } });
return Arrays.asList(new Object[][] { { "perf_outline", "perf_text" }, { "perf_basic", "perf_outline" } });
}

/**
Expand Down
4 changes: 2 additions & 2 deletions ...clipse.ui.tests.performance/src/org/eclipse/ui/tests/performance/OpenCloseEditorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public class OpenCloseEditorTest extends PerformanceTestCaseJunit4 {

@Parameters(name = "{index}: {0}")
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][] { { "perf_basic" }, { "perf_outline" }, { "java" } });
return Arrays.asList(new Object[][] { { "perf_basic" }, { "perf_outline" }, { "perf_text" } });
}


Expand Down Expand Up @@ -85,7 +85,7 @@ public void test() throws Throwable {
stopMeasuring();
});

if (extension.equals("java")) {
if (extension.equals("perf_text")) {
tagAsSummary("UI - Open/Close Editor", Dimension.ELAPSED_PROCESS);
}
commitMeasurements();
Expand Down
4 changes: 2 additions & 2 deletions ...pse.ui.tests.performance/src/org/eclipse/ui/tests/performance/OpenMultipleEditorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public class OpenMultipleEditorTest extends PerformanceTestCaseJunit4 {

@Parameters(name = "{index}: closeAll: {0} - closeEach: {1}")
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][] { { "perf_basic", true }, { "perf_outline", true }, { "java", true },
{ "perf_basic", false }, { "perf_outline", false }, { "java", false } });
return Arrays.asList(new Object[][] { { "perf_basic", true }, { "perf_outline", true }, { "perf_text", true },
{ "perf_basic", false }, { "perf_outline", false }, { "perf_text", false } });
}

public OpenMultipleEditorTest(String extension, boolean closeAll) {
Expand Down
4 changes: 2 additions & 2 deletions ...ipse.ui.tests.performance/src/org/eclipse/ui/tests/performance/UIPerformanceTestRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class UIPerformanceTestRule extends ExternalResource {
public static final String PROJECT_NAME = "Performance Project";

private static final String INTRO_VIEW = "org.eclipse.ui.internal.introview";
public static final String[] EDITOR_FILE_EXTENSIONS = { "perf_basic", "perf_outline", "java" };
public static final String[] EDITOR_FILE_EXTENSIONS = { "perf_basic", "perf_outline", "perf_text" };

@Override
protected void before() throws Throwable {
Expand Down Expand Up @@ -67,7 +67,7 @@ public static IProject getTestProject() {
}

private static void setUpProject() throws CoreException {
// Create a java project.
// Create a performance project.
IProject testProject = getTestProject();
testProject.create(null);
testProject.open(null);
Expand Down
Loading