Skip to content

Comments

Support AspectJ in Gradle projects#3671

Merged
fbricon merged 1 commit intoeclipse-jdtls:mainfrom
snjeza:issue-3670
Jan 13, 2026
Merged

Support AspectJ in Gradle projects#3671
fbricon merged 1 commit intoeclipse-jdtls:mainfrom
snjeza:issue-3670

Conversation

@snjeza
Copy link
Contributor

@snjeza snjeza commented Jan 11, 2026

@fbricon
Copy link
Contributor

fbricon commented Jan 12, 2026

It seems it would remove AJ plugin configuration from existing eclipse .project files. We're already getting some flak because jdtls adds some filters, but that's less destructive than removing config

@snjeza
Copy link
Contributor Author

snjeza commented Jan 12, 2026

It seems it would remove AJ plugin configuration from existing eclipse .project files. We're already getting some flak because jdtls adds some filters, but that's less destructive than removing config

I have fixed it.

@fbricon
Copy link
Contributor

fbricon commented Jan 12, 2026

/test this please

@fbricon
Copy link
Contributor

fbricon commented Jan 12, 2026

@snjeza you need to add gradle/aspectj/init.gradle, to org.eclipse.jdt.ls.core/build.properties

But with or without enabling aspectjSupport, I still see 270 errors in spring-security

@snjeza
Copy link
Contributor Author

snjeza commented Jan 12, 2026

you need to add gradle/aspectj/init.gradle, to org.eclipse.jdt.ls.core/build.properties

I have added it.

But with or without enabling aspectjSupport, I still see 270 errors in spring-security

These errors are not related to AspectJ.

@fbricon
Copy link
Contributor

fbricon commented Jan 12, 2026

OK it seems I had to do a clean gradle build to actually see the differences before and after. Anyways. @snjeza could you please add some unit tests to ensure we don't regress in the future?

@fbricon fbricon merged commit 1b9b053 into eclipse-jdtls:main Jan 13, 2026
2 of 3 checks passed
@fbricon
Copy link
Contributor

fbricon commented Jan 13, 2026

Thanks @snjeza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AspectJ in Gradle projects

2 participants