Skip to content

Comments

chore: Remove unnecessary entries from che configmap#2085

Merged
tolusha merged 2 commits intomainfrom
23723
Feb 13, 2026
Merged

chore: Remove unnecessary entries from che configmap#2085
tolusha merged 2 commits intomainfrom
23723

Conversation

@tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 11, 2026

What does this PR do?

Remove unnecessary entries from che configmap

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#23723

How to test this PR?

  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh

or

build/scripts/docker-run.sh /bin/bash -c "
  oc login \
    --token=<...> \
    --server=<...> \
    --insecure-skip-tls-verify=true && \
  build/scripts/olm/test-catalog-from-sources.sh
"

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh

Common Test Scenarios

  • Deploy Eclipse Che
  • Start an empty workspace
  • Open terminal and build/run an image
  • Stop a workspace
  • Check operator logs for reconciliation errors or infinite reconciliation loops

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha requested a review from akurinnoy February 11, 2026 13:43
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2026

New changes are detected. LGTM label has been removed.

@tolusha
Copy link
Contributor Author

tolusha commented Feb 12, 2026

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Feb 12, 2026

/retest

@tolusha tolusha merged commit 253500b into main Feb 13, 2026
21 checks passed
@tolusha tolusha deleted the 23723 branch February 13, 2026 09:37
rohanKanojia added a commit to rohankanojia-forks/chectl that referenced this pull request Feb 17, 2026
Remove workspace engine compatibility check that read the removed
CHE_DEVWORKSPACES_ENABLED ConfigMap field.

Related to eclipse-che/che-operator#2085

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
tolusha pushed a commit to che-incubator/chectl that referenced this pull request Feb 18, 2026
* chore (deps) : migrate yarn from v1 to v4

- Migrates chectl from Yarn 1.22.22 to Yarn 4.12.0
  - Replaces git dependencies (operator repos) with custom fetch script
  - Updates all CI/CD workflow to use Corepack and immutable installs for reproducible builds
  - Adds Yarn 4 binary (.yarn/releases/) to repository for self-contained builds
- fix failures in e2e tests due to methods not being resolved
  - Use require-style import for execa in context, kube-client, and platform tasks
  - In context.ts, support both CJS and ESM interop (execa vs execa.default)
  - Fixes TypeError when running server:deploy and other commands in CI e2e

Signed-off-by: Rohan Kumar <rohaan@redhat.com>

* fix(server): remove obsolete DevWorkspace compatibility check

Remove workspace engine compatibility check that read the removed
CHE_DEVWORKSPACES_ENABLED ConfigMap field.

Related to eclipse-che/che-operator#2085

Signed-off-by: Rohan Kumar <rohaan@redhat.com>

---------

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants