Draft
Conversation
Add 're-add' action to situated and separate chat, add removedTracks array to playlist document, and make PUT `.../:trackId/removed` support re-adding removed tracks.
TODO add other checks for other endpoints like `.../:trackId/removed`?
Collaborator
Author
|
This will close #67 as milestone 1 removal behavior will not be necessary when this is implemented |
Refactor api types for track search and tracks within `.../playlists/:id` to have just the data needed by the frontend, and move some of the processing from the frontend in several places to the backend in one place. These were done together so the draft addition track's data can be mocked in `SearchResults.tsx` `addButtonOnClick` callback. This will now allow spotify data on removed tracks to be saved when they are removed for #87.
When there were multiple removed tracks and one of them was re-added, the other removed tracks disappeared because I assumed that if I leave off the second parameter to splice it would default to 1. (This behavior likely varied depending on the position of the re-added track within the removed tracks array, so maybe it didn't always happen).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft pull request to resolve #87.
Close #88.