build: fix python search for gobject integration#266
Open
DjLegolas wants to merge 3 commits intoebassi:masterfrom
Open
build: fix python search for gobject integration#266DjLegolas wants to merge 3 commits intoebassi:masterfrom
DjLegolas wants to merge 3 commits intoebassi:masterfrom
Conversation
DjLegolas
force-pushed
the
fix-python-issue
branch
from
5f87b1d to
cd0b5e6
Compare
DjLegolas
changed the title
DjLegolas
force-pushed
the
fix-python-issue
branch
from
cd0b5e6 to
69c64ca
Compare
Owner
|
Would it be possible to split it into two separate commits:
and rebase it on the main development branch? I've changed the minimum required version of Meson to 1.0. Also, I'm not sure why the build hasn't started any check; I don't have a Windows machine, so I rely on the CI pipeline to check if it's actually working. |
DjLegolas
force-pushed
the
fix-python-issue
branch
4 times, most recently
from
8b2563e to
84ad61a
Compare
Owner
|
From the build log: |
DjLegolas
force-pushed
the
fix-python-issue
branch
from
c7e28e8 to
8ab2d7a
Compare
DjLegolas
force-pushed
the
fix-python-issue
branch
2 times, most recently
from
83fec69 to
595682e
Compare
Author
|
Well, still need to understand why it's failing (it fails to find something...) |
DjLegolas
force-pushed
the
fix-python-issue
branch
10 times, most recently
from
a65ac8f to
2876d7c
Compare
When compiling with Gobject integration on Windows, the build fails because it finds the incorrect python interpreter. Closes: ebassi#265
DjLegolas
force-pushed
the
fix-python-issue
branch
from
2876d7c to
4c9ef34
Compare
DjLegolas
force-pushed
the
fix-python-issue
branch
2 times, most recently
from
153de4f to
df00f38
Compare
DjLegolas
force-pushed
the
fix-python-issue
branch
5 times, most recently
from
5599cb5 to
d3711eb
Compare
DjLegolas
force-pushed
the
fix-python-issue
branch
from
d3711eb to
f4d5e01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265.
Proposed changes:
python3search fromsrc/meson.build.Gobjectintegration.