rusk: map dispatch parse errors to 404/422#4032
Open
Neotamandua wants to merge 1 commit intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated request parsing error type for RUES dispatch and maps specific parsing failures to more appropriate HTTP status codes (404/422), with added test coverage.
Changes:
- Added
RequestParseErrorand updatedRuesDispatchEvent::from_requestto return it. - Updated request handling to translate parse errors into 404 (invalid path) / 422 (invalid payload) responses.
- Added tests asserting the new status code behavior and generalized a status/body assertion helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rusk/src/lib/http/event.rs | Introduces RequestParseError and replaces panicking/opaque parsing failures with typed parse errors. |
| rusk/src/lib/http.rs | Maps RequestParseError to 404/422/500 responses and adds tests for invalid path and invalid UTF-8 payload handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.