Open
Conversation
siexp
requested review from
Neotamandua and
herr-seppia
and removed request for
Neotamandua
herr-seppia
reviewed
Jun 13, 2025
Member
herr-seppia
left a comment
herr-seppia
left a comment
There was a problem hiding this comment.
LGTM overall,
only thing is that you should rewrite the commit history to adapt to our standard:
- A commit cannot touch files belonging to different modules
- Every commit should be prefixed with the module name
- A CHANGELOG entry should be added
So, in your case should be something like:
workspace: add idea and c header to git ignorewallet-core: add support for GO FFI
Member
There was a problem hiding this comment.
If this file is autogenerated, it should be ignored in git.
Furthermore, the command to generate it should be part of our Makefile
This can be done in a followup issue
Comment on lines
157
to
164
| #[cfg(target_family = "wasm")] | ||
| let ptr = mem::malloc((4 + bytes.len()) as u32); | ||
| #[cfg(target_family = "wasm")] | ||
| let ptr = ptr as *mut u8; | ||
|
|
||
| #[cfg(not(target_family = "wasm"))] | ||
| let ptr = mem::allocate(4 + bytes.len()); | ||
|
|
Member
There was a problem hiding this comment.
Let's open a followup issue to wrap this repeated code in a separate function
gootsolution
force-pushed
the
ffi-to-go-adoption
branch
from
180d5ff to
884a623
Compare
gootsolution
force-pushed
the
ffi-to-go-adoption
branch
from
884a623 to
76b491b
Compare
gootsolution
force-pushed
the
ffi-to-go-adoption
branch
from
8314385 to
56866d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.