Fix incorrect type in ManifestRegistrar#finalize!#235
Merged
solnic merged 2 commits intodry-rb:mainfrom Jun 15, 2022
Merged
Conversation
alassek
force-pushed
the
fix-manifest-registrar
branch
from
9737bc6 to
29787a9
Compare
solnic
reviewed
Jun 14, 2022
Member
solnic
left a comment
solnic
left a comment
There was a problem hiding this comment.
Thanks for addressing this. Do you think you could add a corresponding test too? 🙏🏻
Contributor
Author
|
Sure, do you have any thoughts about the Zeitwerk failures here? I don't think they're related to my changes but I can look into it. |
`#finalize!` is sending the basename directly to `#call`, which expects a Dry::System::Identifier. This means that if you configure a `registrations_dir`, putting any file in that directory will lead to an exception during finalization. This appears to have been introduced during dry-rb#181
This is using a private interface that changed in 2.6 We probably want to support older versions for a while, so I'm supporting both.
alassek
force-pushed
the
fix-manifest-registrar
branch
from
29787a9 to
9266d0e
Compare
Contributor
Author
|
I added a test to the integration spec that triggers the bug. Also fixed the Zeitwerk failures due to a private interface change. |
Member
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#finalize!is sending the basename directly to#call, which expects aDry::System::Identifier.This means that if you configure a
registrations_dir, putting any file in that directory will lead to an exception during finalization.This appears to have been introduced during #181