Skip to content

Conversation

@DieterHolvoet
Copy link
Contributor

Workaround for an issue discussed in #6481.

@DieterHolvoet DieterHolvoet requested a review from weitzman January 6, 2026 13:14
Comment on lines 499 to 500
assert($this->logger instanceof SuccessInterface);
$this->logger->success(
Copy link
Member

@weitzman weitzman Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt we use io when we use success()? Thats what fieldDelete is doing ... Oh, its because we should a hyperlink later. I would rather give up the hyperlink than make success() usage inconsistent. or lets fix io so it can print hyperlinks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used logger before, I changed it in #6468. Changing it back now to work around the hyperlink issue. Already spent a lot of time on #6481, don't really feel like diving into that hyperlink issue now. Would be a shame to lose the hyperlink here, I actually use it a lot.

@weitzman
Copy link
Member

weitzman commented Jan 6, 2026

I'm OK with using logger in 13.x, but 14.x can't use logger. We want to support injecting a plain PSR logger and that doesnt have success().

@weitzman
Copy link
Member

weitzman commented Jan 6, 2026

Feel free to emit a regular link (i.e. not <href>). Most terminals support clicking on those as well. On Mac Iterm2, you control click them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants