Conversation
| @@ -0,0 +1,8 @@ | |||
| -server | |||
| -Xms8g | |||
There was a problem hiding this comment.
these settings make little sense for many types of hardware
There was a problem hiding this comment.
I agree. These conf items are really dependent. We can put a better default here or we could just leave them as placeholder so that users can change these templates.
|
@xiaoyao1991 it doesn't look like this docker druid will actually work for a single node setup |
|
@fjy Right. This is for having different images for different node types. One can still refer to the setup in the all-in-one folder for a single node setup though. |
|
@xiaoyao1991 can we add some docs about example hardware for these docker configs? i think they match what we propose in the clustered docs |
|
@fjy Sure, and in fact, I copied the configs from https://github.com/druid-io/druid/tree/master/examples/conf/druid. Should I simply say refer to the http://druid.io/docs/latest/configuration/production-cluster.html for the docs that you are suggesting? Actually, my expectation on this is that users should pull these templates and reconfigure before running. These images are not in the docker hub anyway(since I don't have the permission to druidio namespace), so no way people can pull these images from somewhere and use them directly. Every user will have their own settings, including how they wish to ingest data(which is not covered in this PR). The templates in this PR only provide a layout for a containerized druid cluster. What do you think? |
|
@xiaoyao1991 can we add docs on minimum hardware required for the remote cluster to work? |
|
It's a pity that this never got merged. |
3 participants
#21